Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Unify instruction set definition (#33730)" #33901

Merged
merged 1 commit into from
Mar 21, 2020

Conversation

davidwrighton
Copy link
Member

This reverts commit f80a514.

Should fix #33895, and #33897

@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Mar 21, 2020
@ghost
Copy link

ghost commented Mar 21, 2020

Hello @davidwrighton!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 10 minutes. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@BruceForstall
Copy link
Member

@davidwrighton @jkotas If you see them, please notify @dotnet/jit-contrib on changes to JIT-EE interface GUID (including reversions). Thanks.

@jkotas jkotas merged commit bb83f1b into dotnet:master Mar 21, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 10, 2020
@davidwrighton davidwrighton deleted the revert_instruction_set_unify branch April 20, 2021 17:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AsciiUtilityTests failing in CI and PR
4 participants