Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove symbol stripping from pipeline scripts #33911

Merged
merged 2 commits into from
Mar 25, 2020
Merged

Remove symbol stripping from pipeline scripts #33911

merged 2 commits into from
Mar 25, 2020

Conversation

am11
Copy link
Member

@am11 am11 commented Mar 21, 2020

Symbols stripping is unconditionally on for native builds.

Symbols stripping is unconditionally on for native builds.
@am11 am11 marked this pull request as ready for review March 21, 2020 11:32
@am11
Copy link
Member Author

am11 commented Mar 21, 2020

cc @janvorli

Copy link
Member

@janvorli janvorli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@am11
Copy link
Member Author

am11 commented Mar 24, 2020

@janvorli, resolved the merge conflict, would be nice to get this merged before there are more of them. :)

@janvorli
Copy link
Member

@janvorli I've tried before, but there were some weird failures, I've tried to restart the legs few times without much success. I'll keep an eye on this ...

@am11
Copy link
Member Author

am11 commented Mar 25, 2020

Formatting job failure is unrelated, happened during the package restore:

Invoke-WebRequest : Unable to read data from the transport connection: An existing connection was forcibly closed by

@janvorli janvorli merged commit 5369c71 into dotnet:master Mar 25, 2020
@am11 am11 deleted the feature/symbol-stripping-on-by-default branch March 25, 2020 15:44
@ghost ghost locked as resolved and limited conversation to collaborators Dec 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants