Remove duplicates and fix namespaces in S.T.RegularExpressions.Tests #33917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephentoub
reviewed
Mar 21, 2020
stephentoub
reviewed
Mar 21, 2020
| @@ -1030,7 +1015,6 @@ public static IEnumerable<object[]> RegexTestCases() | |||
| yield return new object[] { @"^(((?<foo>\()[^()]*)+((?<bar-foo>\))[^()]*)+)+(?(foo)(?!))$", RegexOptions.None, "((a(b))c))","Fail." }; | |||
| yield return new object[] { @"^(((?<foo>\()[^()]*)+((?<bar-foo>\))[^()]*)+)+(?(foo)(?!))$", RegexOptions.None, ")(","Fail." }; | |||
| yield return new object[] { @"^(((?<foo>\()[^()]*)+((?<bar-foo>\))[^()]*)+)+(?(foo)(?!))$", RegexOptions.None, "((a((b))c)","Fail." }; | |||
| yield return new object[] { @"b", RegexOptions.RightToLeft, "babaaa", "Pass. Group[0]=(2,1)" }; | |||
There was a problem hiding this comment.
Where is this one duplicated?
There was a problem hiding this comment.
stephentoub
reviewed
Mar 21, 2020
| @@ -28,9 +28,6 @@ public static IEnumerable<object[]> Match_Basic_TestData() | |||
| // Testing control character escapes???: "2", "(\u0032)" | |||
| yield return new object[] { "(\u0034)", "4", RegexOptions.None, 0, 1, true, "4", }; | |||
|
|
|||
| // Using *, +, ?, {}: Actual - "a+\\.?b*\\.?c{2}" | |||
| yield return new object[] { @"a+\.?b*\.+c{2}", "ab.cc", RegexOptions.None, 0, 5, true, "ab.cc" }; | |||
There was a problem hiding this comment.
Where is this one duplicated?
There was a problem hiding this comment.
|
Forgot to mention that I used a VSCode extension for identifying and trimming most of the duplicates. |
stephentoub
approved these changes
Mar 21, 2020
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #33915 (VSTest runner logs duplicate test rows)