Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clrcompression static library #33922

Merged
merged 2 commits into from
Mar 22, 2020
Merged

Add clrcompression static library #33922

merged 2 commits into from
Mar 22, 2020

Conversation

nxtn
Copy link
Contributor

@nxtn nxtn commented Mar 22, 2020

Contributes to dotnet/corert#5496

Uses the lib prefix per dotnet/core-setup#8659

@nxtn nxtn marked this pull request as ready for review March 22, 2020 05:28
Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do this for all other libraries shim currently and this one is the only outlier. It is something we may need to revisit in future.

@jkotas jkotas merged commit 24c4cb1 into dotnet:master Mar 22, 2020
@jkotas
Copy link
Member

jkotas commented Mar 22, 2020

Related #3447

@nxtn nxtn deleted the clrcompression branch March 22, 2020 23:22
)

SET_TARGET_PROPERTIES(clrcompression-static PROPERTIES PREFIX "")
SET_TARGET_PROPERTIES(clrcompression-static PROPERTIES OUTPUT_NAME libclrcompression)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NextTurn I have a couple of questions:

  • Why do we add the lib prefix on Windows? This naming convention is Unix only.
  • If we really want to do that for some reason, why don't we use the PREFIX property to do that instead of setting the PREFIX to an empty string and modifying the OUTPUT_NAME?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we add the lib prefix on Windows? This naming convention is Unix only.

There is already a clrcompression.lib on Windows serving as an import library. The lib prefix is taken from a similar library libnethost.lib as per discussion in dotnet/core-setup#8659.

If we really want to do that for some reason, why don't we use the PREFIX property to do that instead of setting the PREFIX to an empty string and modifying the OUTPUT_NAME?

Setting the PREFIX to lib seems to work as well... I'll take another look later.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about we set PREFIX to lib and then OUTPUT_NAME to clrcompression?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I have not realized before that we need to set the output name anyways, as it would be clrcompression-static by default. So I guess it is not worth the hassle to spend time changing it to set the PREFIX to lib. Please feel free to keep it as is.

@ghost ghost locked as resolved and limited conversation to collaborators Dec 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants