Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase number of attempts before failure in ECDSA-DER #33933

Merged
merged 2 commits into from
Mar 22, 2020
Merged

Increase number of attempts before failure in ECDSA-DER #33933

merged 2 commits into from
Mar 22, 2020

Commits on Mar 22, 2020

  1. Increase number of attempts before failure in ECDSA-DER 

    Of the four test keys, 3 have a 75% chance of being smaller than max on each call.
 (1 - 0.75) ^ 10 = 9.5e-7, so failure happens slightly more rarely than 1 in a million.

The fourth test key only has a 43.75% chance (1 - (.75 * .75)) of being smaller,
and (1 - .4375) ^ 10 = 3.1e-3, so slightly more likely than 3 per thousand.

Raising the iteration count to 36 brings the fourth key odds of failure to about 1 in a billion (1.01e-9).
36 iterations makes the other 3 fail at 1e-22; but 1e-9 is attained at 15 iterations.
    @bartonjs
    bartonjs committed Mar 22, 2020
    Configuration menu
    Copy the full SHA
    823d2c8 View commit details
    Browse the repository at this point in the history

  2. Billion, with a b.

    @bartonjs
    bartonjs committed Mar 22, 2020
    Configuration menu
    Copy the full SHA
    6cb95fb View commit details
    Browse the repository at this point in the history