Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable failing WinHttpHandler HTTP/2 test #34011

Merged
merged 1 commit into from
Mar 24, 2020

Conversation

stephentoub
Copy link
Member

#33930
This has been failing in the majority of PRs.
cc: @ManickaP, @CourtneyThurston

@davidsh
Copy link
Contributor

davidsh commented Mar 24, 2020

@alnikola

@davidsh
Copy link
Contributor

davidsh commented Mar 24, 2020

Won't this PR also disable this test on SocketsHttpHandler as well?

@davidsh davidsh added this to the 5.0 milestone Mar 24, 2020
@stephentoub
Copy link
Member Author

Won't this PR also disable this test on SocketsHttpHandler as well?

Yes. But we don't currently expose the difference in an easily consumable way to the tests, as far as I can see, and I didn't want to churn the tests just to disable this.

@stephentoub stephentoub merged commit 7c1ae8d into dotnet:master Mar 24, 2020
@stephentoub stephentoub deleted the disablehttp2test branch March 24, 2020 17:09
@ManickaP
Copy link
Member

I'll look into it.

@ghost ghost locked as resolved and limited conversation to collaborators Dec 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants