Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compilation of System.Net.Security.Native on Linux #34018

Merged
merged 1 commit into from
Mar 24, 2020

Conversation

akoeplinger
Copy link
Member

@akoeplinger akoeplinger commented Mar 24, 2020

It was accidentally moved to a OSX/iOS-only conditional in #33970 but it should be built on Linux too.

@stephentoub any idea why this was green in #33970? are the tests which rely on System.Net.Security.Native only run in outerloop?

It was accidentally moved to a OSX/iOS-only conditional in dotnet#33970 but it should be built on Linux too.
@akoeplinger akoeplinger changed the title Fix compilation of System.Net.Security.Native Fix compilation of System.Net.Security.Native on Linux Mar 24, 2020
@stephentoub
Copy link
Member

any idea why this was green in #33970? are the tests which rely on System.Net.Security.Native only run in outerloop?

It's certainly possible that all of our negotiate-related tests are outer loop. @davidsh?

In the future we should run outer loop tests on anything like this that impacts System.Net, as there's a fair amount of validation done in outer loop that's not done in inner loop, at least today.

@davidsh
Copy link
Contributor

davidsh commented Mar 24, 2020

It's certainly possible that all of our negotiate-related tests are outer loop. @davidsh?

Linux specific ones are part of the 'runtime-libraries enterprise-linux' pipeline. It is neither innerloop or outerloop but a separate pipeline. It runs all the time for every PR but only those PRs that touch System.Net code.

But this problem described here sounds like a compilation error which should have been caught in the regular CI validation.

@davidsh davidsh added this to the 5.0 milestone Mar 24, 2020
@akoeplinger
Copy link
Member Author

@davidsh I see. The PR only touched the CMakeLists.txt file but not any of the source files so the pipeline didn't get triggered:

- src/libraries/Native/Unix/System.Net.Security.Native/*

There were no compilation errors since building of the library was simply skipped.

@akoeplinger akoeplinger merged commit 26eb70b into dotnet:master Mar 24, 2020
@akoeplinger akoeplinger deleted the fix-condition branch March 24, 2020 17:20
@ghost ghost locked as resolved and limited conversation to collaborators Dec 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants