-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use RtlUnwind instead of RtlUnwindEx. #34188
Conversation
I couldn't figure out the best area label to add to this PR. Please help me learn by adding exactly one area label. |
Because the formerly uninitialized scratch context is now an input.
Is this fixing any observable bug? |
This change doesn't seem necessary, RtlUnwindEx fills in the passed in context with the current context using RtlCaptureContext. RtlUnwind until very recent Windows 10 was implemented in the OS literally as we do in this function. |
This code used to be correct, but is no longer. |
Ok, what does not work with the code that we have there today? Note that this code is present in all .NET Framework and .NET Core runtimes shipped in last 15+ years. |
It is not clearly deterministic. |
It is also a little smaller but that isn’t the point. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, this looks like an improvement. Thanks
Because the formerly uninitialized scratch context is now an input.