Add notifyInstructionSetUsage api to jit interface #34209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
davidwrighton
commented
Mar 27, 2020
•
davidwrighton
commented
- Add api to be used when the jit is to notify the VM of any usage of higher level instruction sets
- Note that this change does nothing using the api. This is merely a scaffolding change to prepare for functional changes later
- There is also scaffolding in the jit to JITDUMP any usage of the api
…d when the jit is to notify the VM of any usage of higher level instruction sets- Note that this change does nothing using the api. This is merely a scaffolding change to prepare for functional changes later - There is also scaffoling in the jit to JITDUMP any usage of the api
Dotnet-GitSync-Bot
added
the
area-CodeGen-coreclr
lpereira
reviewed
Mar 27, 2020
AndyAyersMS
approved these changes
Mar 27, 2020
|
|
||
| default: | ||
| return ""; |
There was a problem hiding this comment.
Make this something findable?
Suggested change
| return ""; | |
| return "UnknownInstructionSet"; |
|
Hello @davidwrighton! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.