[CBOR] Implement Write/ReadEncodedValue() methods #34650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging @tarekgh as an area owner |
|
Tagging @bartonjs as an area owner |
eiriktsarpalis
force-pushed
the
feature/cbor
branch
from
ca72237
to
ccffb90
Compare
bartonjs
reviewed
Apr 8, 2020
src/libraries/System.Security.Cryptography.Encoding/tests/Cbor.Tests/CborWriterTests.String.cs
Outdated
Show resolved
Hide resolved
bartonjs
reviewed
Apr 8, 2020
src/libraries/System.Security.Cryptography.Encoding/tests/Cbor.Tests/CborReaderTests.String.cs
Show resolved
Hide resolved
bartonjs
reviewed
Apr 8, 2020
src/libraries/System.Security.Cryptography.Encoding/tests/Cbor.Tests/CborWriterTests.cs
Show resolved
Hide resolved
bartonjs
reviewed
Apr 8, 2020
...ibraries/System.Security.Cryptography.Encoding/tests/Cbor.Tests/CborReaderTests.SkipValue.cs
Show resolved
Hide resolved
|
Functional code LGTM, but (as already noted) I'd like to see a bit more scenario-based testing because of the sheer amount of context that is implied by the one call to |
bartonjs
approved these changes
Apr 8, 2020
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #32046 and #32047.
I've also made changes related to wrapping utf8 string related
EncoderFallbackException's andDecoderFallbackExceptions withArgumentExceptionandFormatExceptionrespectively.