Support ECParameters that contain only D (macOS). #34654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All platforms support it now.
|
Tagging @bartonjs as an area owner |
|
/azp run libraries |
|
Commenter does not have sufficient privileges for PR 34654 in repo dotnet/runtime |
|
One of these days... |
|
@bartonjs can you re-try the failed jobs if there is reasonable belief they won't get rate limited again? |
|
Well, libraries-OSX ran and passed, which seems the most relevant. I'll pursue green across the board after reviewing the code, so that we're not just making the problem worse before throwing new commits at it 😄. |
bartonjs
approved these changes
Apr 8, 2020
|
Nailed it in one. Nice work @vcsjones 🎉. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the MacOS portion of #33874.
This also updates the
ECParameters.Validateexception to reflect the relaxation of theQrequirement.Fixes #33744