Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

System.Diagnostics Tracing APIs #35220

Merged
merged 2 commits into from
Apr 23, 2020
Merged

System.Diagnostics Tracing APIs #35220

merged 2 commits into from
Apr 23, 2020

Conversation

tarekgh
Copy link
Member

@tarekgh tarekgh commented Apr 20, 2020 •
edited
Loading

Fixes #31373

@Dotnet-GitSync-Bot
Copy link
Collaborator

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost
Copy link

ghost commented Apr 20, 2020

Tagging subscribers to this area: @tarekgh, @tommcdon
Notify danmosemsft if you want to be subscribed.

@tarekgh
Copy link
Member Author

tarekgh commented Apr 20, 2020 •
edited
Loading

dotnet/designs#98
dotnet/apireviews#117
tarekgh#1
#32660
https://github.com/noahfalk/ActivitiesExperiment/tree/68df578b7330d6851c4b8a864d7d5ed72bcc3f7c

@tarekgh
Copy link
Member Author

tarekgh commented Apr 20, 2020

@noahfalk could you please take one last look?

@tarekgh tarekgh requested a review from noahfalk April 20, 2020 21:14
@tarekgh tarekgh self-assigned this Apr 20, 2020
@jaredpar jaredpar mentioned this pull request Apr 21, 2020
Closed
noahfalk
noahfalk approved these changes Apr 22, 2020
View reviewed changes
Copy link
Member

@noahfalk noahfalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great Tarek.

I added a few comments on minor issues and a couple thoughts on perf, but nothing that would be any obstacle to a preview.

...aries/System.Diagnostics.DiagnosticSource/ref/System.Diagnostics.DiagnosticSourceActivity.cs Show resolved Hide resolved
src/libraries/System.Diagnostics.DiagnosticSource/src/System/Diagnostics/ActivitySource.cs Show resolved Hide resolved
src/libraries/System.Diagnostics.DiagnosticSource/src/System/Diagnostics/ActivitySource.cs Show resolved Hide resolved
src/libraries/System.Diagnostics.DiagnosticSource/src/System/Diagnostics/ActivitySource.cs Outdated Show resolved Hide resolved
src/libraries/System.Diagnostics.DiagnosticSource/src/System/Diagnostics/ActivitySource.cs Show resolved Hide resolved
@tarekgh
Copy link
Member Author

tarekgh commented Apr 23, 2020

merging it as the CI failures are not related and tracked too.

@tarekgh tarekgh merged commit 8baf392 into dotnet:master Apr 23, 2020
tarekgh added a commit to tarekgh/runtime that referenced this pull request Apr 23, 2020
@tarekgh
System.Diagnostics Tracing APIs (dotnet#35220)
fe6a756 
* System.Diagnostics Tracing APIs

* address the feedback
@tarekgh tarekgh mentioned this pull request Apr 23, 2020
Merged
tarekgh added a commit that referenced this pull request Apr 23, 2020
@tarekgh
System.Diagnostics Tracing APIs (#35220) (#35326)
88c069b 
* System.Diagnostics Tracing APIs

* address the feedback
@ghost ghost locked as resolved and limited conversation to collaborators Dec 9, 2020
@tarekgh tarekgh deleted the SystemDiagnosticsAPIs branch March 15, 2021 19:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@noahfalk noahfalk noahfalk approved these changes

Assignees

@tarekgh tarekgh

Labels
area-System.Diagnostics.Tracing new-api-needs-documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support OpenTelemetry concepts on Activity
3 participants
@tarekgh @Dotnet-GitSync-Bot @noahfalk