Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CBOR] Implement Conformance Levels #35246

Merged
merged 42 commits into from
May 2, 2020
Merged

[CBOR] Implement Conformance Levels #35246

merged 42 commits into from
May 2, 2020

Conversation

eiriktsarpalis
Copy link
Member

@eiriktsarpalis eiriktsarpalis commented Apr 21, 2020 •
edited
Loading

Contributes to #32046 and #32047.

  • Define conformance levels for Strict mode, RFC7049 canonical mode and CTAP2 canonical mode.
  • Implement key sorting in CborWriter.
  • Implement conformance level validation for CborWriter.
  • Implement conformance level validation for CborReader.

Addendum:

  • Implement patching support for indefinite-length data items.
  • Fix SkipValue() conformance and implement a SkipToParent() method.
  • Implement writing and reading multiple root-level values.

@eiriktsarpalis eiriktsarpalis added this to the 5.0 milestone Apr 21, 2020
@ghost
Copy link

ghost commented Apr 21, 2020

Tagging subscribers to this area: @bartonjs, @vcsjones, @krwq
Notify danmosemsft if you want to be subscribed.

@eiriktsarpalis eiriktsarpalis marked this pull request as ready for review April 23, 2020 13:53
@jaredpar jaredpar mentioned this pull request Apr 23, 2020
Closed
eiriktsarpalis and others added 7 commits May 1, 2020 15:05
@eiriktsarpalis @bartonjs
Update src/libraries/System.Security.Cryptography.Encoding/tests/Cbor…
81feca2 
…/CborConformanceLevel.cs

Co-authored-by: Jeremy Barton <jbarton@microsoft.com>
@eiriktsarpalis @bartonjs
Update src/libraries/System.Security.Cryptography.Encoding/tests/Cbor…
a2ccd38 
…/CborReader.Array.cs

Co-authored-by: Jeremy Barton <jbarton@microsoft.com>
@eiriktsarpalis @bartonjs
Update src/libraries/System.Security.Cryptography.Encoding/tests/Cbor…
871b142 
…/CborReader.Tag.cs

Co-authored-by: Jeremy Barton <jbarton@microsoft.com>
@eiriktsarpalis @bartonjs
Update src/libraries/System.Security.Cryptography.Encoding/tests/Cbor…
e0d4780 
…/CborReader.cs

Co-authored-by: Jeremy Barton <jbarton@microsoft.com>
@eiriktsarpalis @bartonjs
Update src/libraries/System.Security.Cryptography.Encoding/tests/Cbor…
0ecf75c 
…/CborWriter.Map.cs

Co-authored-by: Jeremy Barton <jbarton@microsoft.com>
@eiriktsarpalis
address PR feedback
ab0c15a
@eiriktsarpalis
clean up code and add comments; remove unneeded synchronization
0f9a773
@eiriktsarpalis eiriktsarpalis merged commit 412b9c5 into dotnet:master May 2, 2020
@eiriktsarpalis eiriktsarpalis deleted the feature/cbor branch May 2, 2020 21:34
@stephentoub
Copy link
Member

@eiriktsarpalis, please make sure to squash such PRs in the future when merging. Thanks.

@eiriktsarpalis
Copy link
Member Author

please make sure to squash such PRs in the future when merging. Thanks.

My apologies, I assumed I had squash merged it. Not sure why it didn't.

@jaredpar jaredpar mentioned this pull request May 5, 2020
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Dec 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@krwq krwq krwq left review comments

@bartonjs bartonjs bartonjs approved these changes

@Wraith2 Wraith2 Wraith2 left review comments

Assignees
No one assigned
Labels
area-System.Security
Projects
COSE - CBOR Object Signing and Encryp...
  
Awaiting triage
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@eiriktsarpalis @stephentoub @krwq @bartonjs @Wraith2