Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mono] Integrate xharness tool (iOS) #35316

Merged
merged 9 commits into from
Apr 28, 2020
Merged

Conversation

EgorBo
Copy link
Member

@EgorBo EgorBo commented Apr 22, 2020

xharness-tool works but not quite stable: it doesn't quit when tests are finished, also I don't see any file with test results.

Steps to run a test:

./build.sh -c Release -os iOS -subset Mono+Libs

cd src/libraries/System.Numerics.Vectors/tests

dotnet build -c Release /p:TargetOS=iOS /t:Test

@ghost
Copy link

ghost commented Apr 22, 2020

Tagging subscribers to this area: @ViktorHofer
Notify danmosemsft if you want to be subscribed.

@ghost
Copy link

ghost commented Apr 22, 2020

Tagging subscribers to this area: @directhex
Notify danmosemsft if you want to be subscribed.

@premun
Copy link
Member

premun commented Apr 23, 2020

Trying to fix the hang issue here: dotnet/xharness#73

@premun
Copy link
Member

premun commented Apr 23, 2020

The hang is prevented here to unblock you but the app will still fail to install on the Simulator:
dotnet/xharness#74

I am tracking the installation issue here:
dotnet/xharness#69

@mandel-macaque
Copy link
Member

Created two issues to track this:

Should be easy to solve.

@premun
Copy link
Member

premun commented Apr 23, 2020

So fix was already checked couple of hours ago but we have problems with arcade and cannot seem to publish the new package:
https://dev.azure.com/dnceng/internal/_build/results?buildId=613910&view=results

There is a fix in arcade apparently but it will take time. So let me know if this becomes blocker for you and I can send you a manually built package or I can push one to the feed or something that will unblock you

@premun
Copy link
Member

premun commented Apr 25, 2020

@EgorBo looks like the XHarness tool will expect the app to shut down itself after the tests are done, otherwise it doesn't know if there are more logs to come. Is it something you can implement?

@EgorBo
Copy link
Member Author

EgorBo commented Apr 25, 2020

@premun it's already implemented in this PR, see changes in runtime.m https://github.com/dotnet/runtime/pull/35316/files#diff-8c2a0ec87d7100c3ad4942fb4d36a1d4L276

@premun
Copy link
Member

premun commented Apr 25, 2020

@EgorBo if you wish, keep it as a feature and we can add the autoexit option too. But up to you, this seems as less code :)

Also, could I ask you to build a new app for me with the exiting from the dummy test file I sent you on Teams? I will do another round of testing on Monday

@EgorBo EgorBo marked this pull request as ready for review April 28, 2020 12:48
@steveisok steveisok self-requested a review April 28, 2020 15:16
@EgorBo
Copy link
Member Author

EgorBo commented Apr 28, 2020

"In progress" legs are actually green in AzDO.

@EgorBo EgorBo merged commit 1736761 into dotnet:master Apr 28, 2020
@EgorBo EgorBo deleted the integrate-xharness branch May 25, 2020 11:54
@ghost ghost locked as resolved and limited conversation to collaborators Dec 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants