Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add disk usage on osx #35522

Merged
merged 8 commits into from
Apr 28, 2020
Merged

Add disk usage on osx #35522

merged 8 commits into from
Apr 28, 2020

Conversation

jashook
Copy link
Contributor

@jashook jashook commented Apr 27, 2020

This will be used to track the usage over time.

@ghost
Copy link

ghost commented Apr 27, 2020

Tagging subscribers to this area: @ViktorHofer
Notify danmosemsft if you want to be subscribed.

@jashook jashook requested a review from trylek April 27, 2020 16:55
Copy link
Member

@trylek trylek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@jashook
Copy link
Contributor Author

jashook commented Apr 28, 2020

Adding some more stakeholders.

@jashook
Copy link
Contributor Author

jashook commented Apr 28, 2020

This will dump disk usage before and after every build. The before du/df is useful for the jobs that disconnect. I have a sneaking suspicion that the disk size changes. We will not know if this is true or not until we have a disconnect with a df usage before the build on that job.

/cc @MattGal

Copy link
Member

@MattGal MattGal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion:

 ${{ if in(parameters.osGroup, 'OSX', 'iOS','tvOS') }}: 

everywhere.

@jashook
Copy link
Contributor Author

jashook commented Apr 28, 2020

Failures are unrelated.

@jashook jashook merged commit 06f9bfa into dotnet:master Apr 28, 2020
@jashook jashook deleted the add-disk-usage-on-osx branch April 28, 2020 22:54
@ghost ghost locked as resolved and limited conversation to collaborators Dec 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants