Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix build.ps1 script execution error on cmd due to whitespace #35554

Merged
merged 1 commit into from
Apr 28, 2020

Conversation

himanshu8088
Copy link
Contributor

@himanshu8088 himanshu8088 commented Apr 28, 2020

build.cmd unable to execute on command prompt due to white space issue in the file path.

Powershell doesn’t natively support a parameter for a script to run. The default command-line argument is “-command,” which defines the command as though you had typed it at the prompt.
Now although, "%~dp0eng\build.ps1"is quoted in a double quote but it is treated as a string and will not be executed. I found a bug with the code in a file due to the mentioned issue.

The call operator (&) allows you to execute a command, script, or function, I made PR for the bug fix.

Fix #35458

@ghost
Copy link

ghost commented Apr 28, 2020

Tagging subscribers to this area: @ViktorHofer
Notify danmosemsft if you want to be subscribed.

@ViktorHofer
Copy link
Member

@jkoritzinsky can you please review the PR and make sure this doesn't break your multi-arch/configurations work that you were doing?

Copy link
Member

@jkoritzinsky jkoritzinsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validated that this works with the multi-arch/multi-config build feature.

@ViktorHofer
Copy link
Member

ViktorHofer commented Apr 28, 2020

Issue is #13610 (remote executor timing out)

@ViktorHofer ViktorHofer merged commit 2845749 into dotnet:master Apr 28, 2020
@ViktorHofer
Copy link
Member

Thanks @himanshu8088 :)

@ghost ghost locked as resolved and limited conversation to collaborators Dec 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants