Provide dummy runtime_version.h when skipped #35579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With `-skipgenerateversion`, all MSBuild invocations are skipped. In that case, we generate a dummy `version.c` file. Since `runtime_version.h` is added as a required header, generate its dummy variant in the same context.
|
cc @jkotas, with this PR changes, following succeeds (from clean repo): ./src/coreclr/build-runtime.sh -skipgenerateversion -nopgooptimize \
-cmakeargs -DCLR_CMAKE_BUILD_TESTS=1 |
jkotas
reviewed
Apr 28, 2020
|
Thanks for fixing this up! |
jkotas
reviewed
Apr 28, 2020
|
Builds are green on AzDO, but showing up as In-Progress on GitHub. |
jkotas
approved these changes
Apr 29, 2020
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With
-skipgenerateversion, all MSBuild invocations are skipped.In that case, we generate a dummy
version.cfile. Sinceruntime_version.his added as a required header, generate its dummyvariant in the same context.