improve resiliency of process tests #35584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wfurt
added
area-System.Diagnostics
test-enhancement
krwq
reviewed
Apr 28, 2020
krwq
reviewed
Apr 28, 2020
src/libraries/System.Diagnostics.Process/tests/ProcessTests.Unix.cs
Outdated
Show resolved
Hide resolved
krwq
reviewed
Apr 28, 2020
krwq
approved these changes
Apr 28, 2020
danmoseley
reviewed
Apr 28, 2020
src/libraries/System.Diagnostics.Process/tests/ProcessTests.Unix.cs
Outdated
Show resolved
Hide resolved
danmoseley
reviewed
Apr 28, 2020
danmoseley
reviewed
Apr 28, 2020
src/libraries/System.Diagnostics.Process/tests/ProcessTests.Unix.cs
Outdated
Show resolved
Hide resolved
danmoseley
reviewed
Apr 28, 2020
| @@ -2119,7 +2119,7 @@ public void Kill_ExitedChildProcess_DoesNotThrow(bool killTree) | |||
| Process process = CreateProcess(); | |||
| process.Start(); | |||
|
|
|||
| process.WaitForExit(); | |||
| Assert.True(process.WaitForExit(Helpers.PassingTestTimeoutMilliseconds)); | |||
There was a problem hiding this comment.
We already have WaitInMS for this (its 5 mins but that should still be OK)
danmoseley
approved these changes
Apr 28, 2020
stephentoub
reviewed
Apr 29, 2020
| Process[] all = Process.GetProcesses(); | ||
| foreach (Process p in all) | ||
| { | ||
| Console.WriteLine("{0,8} {1}", p.Id, p.ProcessName); |
stephentoub
approved these changes
Apr 29, 2020
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I suspect Kill_ExitedChildProcess_DoesNotThrow is hanging in the WaitForExit so I modify it to use overload with timeout. I also add time limit and some more instrumentation to the Unix version.
Now the test should fail instead of hanging and we should hopefully collect more information.
fixes #35506