Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve cmake version detection #35593

Merged
merged 1 commit into from
Apr 29, 2020
Merged

improve cmake version detection #35593

merged 1 commit into from
Apr 29, 2020

Conversation

wfurt
Copy link
Member

@wfurt wfurt commented Apr 29, 2020

I was trying to build runtime on Centos7 and use available cmake3-3.14.7-1.el7.x86_64 package. That should be sufficient to build but the build complained about old version.

[root@cent runtime]# cmake --version
cmake3 version 3.14.7

CMake suite maintained and supported by Kitware (kitware.com/cmake).

this is because version is prefixed with cmake3 instead of cmake

@ghost
Copy link

ghost commented Apr 29, 2020

Tagging subscribers to this area: @ViktorHofer
Notify danmosemsft if you want to be subscribed.

@jkotas
Copy link
Member

jkotas commented Apr 29, 2020

cc @am11

Copy link
Member

@janvorli janvorli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants