Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nullable: System.Xml, part 2 #35683

Merged
merged 1 commit into from
May 12, 2020
Merged

Nullable: System.Xml, part 2 #35683

merged 1 commit into from
May 12, 2020
+794 −416

Conversation

krwq
Copy link
Member

@krwq krwq commented May 1, 2020

A little bit of schema, some remainders of reader/writer.

@krwq krwq requested a review from a team May 1, 2020 00:16
@ghost
Copy link

ghost commented May 1, 2020

Tagging subscribers to this area: @buyaa-n, @krwq
Notify danmosemsft if you want to be subscribed.

stephentoub
stephentoub approved these changes May 1, 2020
View reviewed changes
Copy link
Member

@stephentoub stephentoub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working through this.

@stephentoub stephentoub closed this May 8, 2020
@stephentoub stephentoub reopened this May 8, 2020
@jaredpar jaredpar mentioned this pull request May 8, 2020
Closed
buyaa-n
buyaa-n approved these changes May 8, 2020
View reviewed changes
Copy link
Member

@buyaa-n buyaa-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@krwq
Copy link
Member Author

krwq commented May 11, 2020

/azp help

@azure-pipelines
Copy link

Supported commands
  • help:
    • Get descriptions, examples and documentation about supported commands
    • Example: help "command_name"
  • list:
    • List all pipelines for this repository using a comment.
    • Example: "list"
  • run:
    • Run all pipelines or specific pipelines for this repository using a comment. Use this command by itself to trigger all related pipelines, or specify specific pipelines to run.
    • Example: "run" or "run pipeline_name, pipeline_name, pipeline_name"
  • where:
    • Report back the Azure DevOps orgs that are related to this repository and org
    • Example: "where"

See additional documentation.

@krwq
Copy link
Member Author

krwq commented May 11, 2020

/azp run runtime (CoreCLR Product Build OSX x64 release)

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@krwq krwq closed this May 11, 2020
@krwq krwq reopened this May 11, 2020
@krwq krwq merged commit 5f2398b into dotnet:master May 12, 2020
@safern safern mentioned this pull request May 13, 2020
Open
@ghost ghost locked as resolved and limited conversation to collaborators Dec 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stephentoub stephentoub stephentoub approved these changes

@buyaa-n buyaa-n buyaa-n approved these changes

Assignees
No one assigned
Labels
area-System.Xml
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@krwq @stephentoub @buyaa-n