Add windows 8 and windows 7 testing for PRs in a reduced way #36096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @ViktorHofer |
safern
force-pushed
the
AddWindows7and8ToPrs
branch
from
7693f66
to
793bf00
Compare
|
Can I get a review here? Would like to merge this to get coverage and protect Rolling builds by running these OSs in PRs as well. |
ericstj
approved these changes
May 8, 2020
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We got more cores on Windows 8 and Windows 7, I don't think enough to the amount of work we where sending previously, but this gets us some coverage on both queues. Windows7 x86 and Windows8.1 x64.
cc: @dotnet/runtime-infrastructure
FYI: @MattGal