Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use CopyTo(arr) instead of creating List<T> first #36228

Merged
merged 5 commits into from
May 12, 2020
Merged

Use CopyTo(arr) instead of creating List<T> first #36228

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1a3195b
Use LINQ ToArray
Youssef1313 May 11, 2020
16ca67f
Update RoType.cs
Youssef1313 May 11, 2020
0e87b4b
Update RoType.cs
Youssef1313 May 11, 2020
ad901e0
Update src/libraries/System.Reflection.MetadataLoadContext/src/System…
Youssef1313 May 11, 2020
52e5b2d
Fix whitespace causing analyzer warnings
stephentoub May 12, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions ...s/System.Reflection.MetadataLoadContext/src/System/Reflection/TypeLoading/Types/RoType.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

using System.Collections.Generic;
using System.Globalization;
using System.Linq;
using StructLayoutAttribute = System.Runtime.InteropServices.StructLayoutAttribute;

namespace System.Reflection.TypeLoading
Expand Down Expand Up @@ -192,9 +193,7 @@ private RoType[] ComputeInterfaceClosure()
}
}

// todo: use IEnumerable<T> extension: return ifcs.ToArray()
List<RoType> list = new List<RoType>(ifcs);
return list.ToArray();
return ifcs.ToArray();
Youssef1313 marked this conversation as resolved.
Show resolved Hide resolved
}

private volatile RoType[]? _lazyInterfaces;
Expand Down