Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add System.Runtime.CompilerServices.IsExternalInit #37763

Merged
merged 2 commits into from Jun 12, 2020

Conversation

@RikkiGibson
Copy link
Contributor

@RikkiGibson RikkiGibson commented Jun 11, 2020

Resolves #34978

The up to date description on how we want to do this is here: #34978 (comment)

Looking at some of the other compiler-known attributes used in modreqs, it seems like the class should be 'static' as well.

I think there is no boilerplate unit test to add for this one because the static class doesn't contain any members.

@Dotnet-GitSync-Bot
Copy link
Collaborator

@Dotnet-GitSync-Bot Dotnet-GitSync-Bot commented Jun 11, 2020

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

Co-authored-by: Jan Kotas <jkotas@microsoft.com>
/// This class should not be used by developers in source code.
/// </summary>
[EditorBrowsable(EditorBrowsableState.Never)]
public static class IsExternalInit

This comment has been minimized.

@stephentoub

stephentoub Jun 12, 2020
Member

I just want to clarify... the issue lists the type as sealed:
#34978 (comment)
but here it's static. static rather than sealed was actually intended?

This comment has been minimized.

@RikkiGibson

RikkiGibson Jun 12, 2020
Author Contributor

Yes, after closer examination of other types used by the compiler in modreqs, we decided this should be a static class similar to IsVolatile

@RikkiGibson
Copy link
Contributor Author

@RikkiGibson RikkiGibson commented Jun 12, 2020

@stephentoub is this ready for merge or is further review needed?

@RikkiGibson
Copy link
Contributor Author

@RikkiGibson RikkiGibson commented Jun 12, 2020

Ping @jaredpar

@jkotas
jkotas approved these changes Jun 12, 2020
@jkotas jkotas merged commit d273780 into dotnet:master Jun 12, 2020
100 checks passed
100 checks passed
dotnet-runtime-perf Build #20200611.81 succeeded
Details
dotnet-runtime-perf (Checkout) Checkout succeeded
Details
dotnet-runtime-perf (CoreCLR Product Build Linux x64 release) CoreCLR Product Build Linux x64 release succeeded
Details
dotnet-runtime-perf (CoreCLR Product Build Windows_NT x64 release) CoreCLR Product Build Windows_NT x64 release succeeded
Details
dotnet-runtime-perf (CoreCLR Product Build Windows_NT x86 release) CoreCLR Product Build Windows_NT x86 release succeeded
Details
dotnet-runtime-perf (Libraries Build Linux x64 Release) Libraries Build Linux x64 Release succeeded
Details
dotnet-runtime-perf (Libraries Build Windows_NT x64 Release) Libraries Build Windows_NT x64 Release succeeded
Details
dotnet-runtime-perf (Libraries Build Windows_NT x86 Release) Libraries Build Windows_NT x86 Release succeeded
Details
dotnet-runtime-perf (Mono Product Build Linux x64 release) Mono Product Build Linux x64 release succeeded
Details
dotnet-runtime-perf (Performance Linux x64 release coreclr net5.0) Performance Linux x64 release coreclr net5.0 succeeded
Details
dotnet-runtime-perf (Performance Linux x64 release mono net5.0) Performance Linux x64 release mono net5.0 succeeded
Details
dotnet-runtime-perf (Performance Windows_NT x64 release coreclr net5.0) Performance Windows_NT x64 release coreclr net5.0 succeeded
Details
dotnet-runtime-perf (Performance Windows_NT x86 release coreclr net5.0) Performance Windows_NT x86 release coreclr net5.0 succeeded
Details
license/cla All CLA requirements met.
Details
runtime Build #20200611.79 succeeded
Details
runtime (Build Android arm Release AllSubsets_Mono) Build Android arm Release AllSubsets_Mono succeeded
Details
runtime (Build Android arm64 Debug AllSubsets_Mono) Build Android arm64 Debug AllSubsets_Mono succeeded
Details
runtime (Build Android x64 Release AllSubsets_Mono) Build Android x64 Release AllSubsets_Mono succeeded
Details
runtime (Build Android x86 Debug AllSubsets_Mono) Build Android x86 Debug AllSubsets_Mono succeeded
Details
runtime (Build Browser wasm Debug AllSubsets_Mono) Build Browser wasm Debug AllSubsets_Mono succeeded
Details
runtime (Build Linux arm Debug AllSubsets_Mono) Build Linux arm Debug AllSubsets_Mono succeeded
Details
runtime (Build Linux x64 Debug AllSubsets_Mono_LLVMJIT) Build Linux x64 Debug AllSubsets_Mono_LLVMJIT succeeded
Details
runtime (Build Linux x64 Release AllSubsets_Mono_LLVMAOT) Build Linux x64 Release AllSubsets_Mono_LLVMAOT succeeded
Details
runtime (Build Linux_musl x64 Release AllSubsets_Mono) Build Linux_musl x64 Release AllSubsets_Mono succeeded
Details
runtime (Build OSX x64 Debug AllSubsets_Mono_LLVMAOT) Build OSX x64 Debug AllSubsets_Mono_LLVMAOT succeeded
Details
runtime (Build OSX x64 Release AllSubsets_Mono_LLVMJIT) Build OSX x64 Release AllSubsets_Mono_LLVMJIT succeeded
Details
runtime (Build iOS arm Release AllSubsets_Mono) Build iOS arm Release AllSubsets_Mono succeeded
Details
runtime (Build iOS arm64 Debug AllSubsets_Mono) Build iOS arm64 Debug AllSubsets_Mono succeeded
Details
runtime (Build iOS x64 Release AllSubsets_Mono) Build iOS x64 Release AllSubsets_Mono succeeded
Details
runtime (Build iOS x86 Debug AllSubsets_Mono) Build iOS x86 Debug AllSubsets_Mono succeeded
Details
runtime (Build tvOS arm64 Release AllSubsets_Mono) Build tvOS arm64 Release AllSubsets_Mono succeeded
Details
runtime (Build tvOS x64 Debug AllSubsets_Mono) Build tvOS x64 Debug AllSubsets_Mono succeeded
Details
runtime (Checkout) Checkout succeeded
Details
runtime (CoreCLR Pri0 Runtime Tests Run Linux arm checked) CoreCLR Pri0 Runtime Tests Run Linux arm checked succeeded
Details
runtime (CoreCLR Pri0 Runtime Tests Run Linux arm64 checked) CoreCLR Pri0 Runtime Tests Run Linux arm64 checked succeeded
Details
runtime (CoreCLR Pri0 Runtime Tests Run Linux x64 checked) CoreCLR Pri0 Runtime Tests Run Linux x64 checked succeeded
Details
runtime (CoreCLR Pri0 Runtime Tests Run OSX x64 checked) CoreCLR Pri0 Runtime Tests Run OSX x64 checked succeeded
Details
runtime (CoreCLR Pri0 Runtime Tests Run Windows_NT arm checked) CoreCLR Pri0 Runtime Tests Run Windows_NT arm checked succeeded
Details
runtime (CoreCLR Pri0 Runtime Tests Run Windows_NT arm64 checked) CoreCLR Pri0 Runtime Tests Run Windows_NT arm64 checked succeeded
Details
runtime (CoreCLR Pri0 Runtime Tests Run Windows_NT x64 checked) CoreCLR Pri0 Runtime Tests Run Windows_NT x64 checked succeeded
Details
runtime (CoreCLR Pri0 Runtime Tests Run Windows_NT x86 checked) CoreCLR Pri0 Runtime Tests Run Windows_NT x86 checked succeeded
Details
runtime (CoreCLR Product Build FreeBSD x64 release) CoreCLR Product Build FreeBSD x64 release succeeded
Details
runtime (CoreCLR Product Build Linux arm checked) CoreCLR Product Build Linux arm checked succeeded
Details
runtime (CoreCLR Product Build Linux arm release) CoreCLR Product Build Linux arm release succeeded
Details
runtime (CoreCLR Product Build Linux arm64 checked) CoreCLR Product Build Linux arm64 checked succeeded
Details
runtime (CoreCLR Product Build Linux arm64 release) CoreCLR Product Build Linux arm64 release succeeded
Details
runtime (CoreCLR Product Build Linux x64 checked) CoreCLR Product Build Linux x64 checked succeeded
Details
runtime (CoreCLR Product Build Linux x64 release) CoreCLR Product Build Linux x64 release succeeded
Details
runtime (CoreCLR Product Build Linux_musl arm64 checked) CoreCLR Product Build Linux_musl arm64 checked succeeded
Details
runtime (CoreCLR Product Build Linux_musl arm64 release) CoreCLR Product Build Linux_musl arm64 release succeeded
Details
runtime (CoreCLR Product Build Linux_musl x64 checked) CoreCLR Product Build Linux_musl x64 checked succeeded
Details
runtime (CoreCLR Product Build Linux_musl x64 release) CoreCLR Product Build Linux_musl x64 release succeeded
Details
runtime (CoreCLR Product Build OSX x64 checked) CoreCLR Product Build OSX x64 checked succeeded
Details
runtime (CoreCLR Product Build OSX x64 release) CoreCLR Product Build OSX x64 release succeeded
Details
runtime (CoreCLR Product Build Windows_NT arm checked) CoreCLR Product Build Windows_NT arm checked succeeded
Details
runtime (CoreCLR Product Build Windows_NT arm release) CoreCLR Product Build Windows_NT arm release succeeded
Details
runtime (CoreCLR Product Build Windows_NT arm64 checked) CoreCLR Product Build Windows_NT arm64 checked succeeded
Details
runtime (CoreCLR Product Build Windows_NT arm64 release) CoreCLR Product Build Windows_NT arm64 release succeeded
Details
runtime (CoreCLR Product Build Windows_NT x64 checked) CoreCLR Product Build Windows_NT x64 checked succeeded
Details
runtime (CoreCLR Product Build Windows_NT x64 release) CoreCLR Product Build Windows_NT x64 release succeeded
Details
runtime (CoreCLR Product Build Windows_NT x86 checked) CoreCLR Product Build Windows_NT x86 checked succeeded
Details
runtime (CoreCLR Product Build Windows_NT x86 release) CoreCLR Product Build Windows_NT x86 release succeeded
Details
runtime (CoreCLR Common Pri0 Test Build AnyOS AnyCPU checked) CoreCLR Common Pri0 Test Build AnyOS AnyCPU checked succeeded
Details
runtime (CoreCLR GCC Product Build Linux x64 checked) CoreCLR GCC Product Build Linux x64 checked succeeded
Details
runtime (Formatting Linux x64) Formatting Linux x64 succeeded
Details
runtime (Formatting Windows_NT x64) Formatting Windows_NT x64 succeeded
Details
runtime (Installer Build and Test coreclr FreeBSD_x64 Release) Installer Build and Test coreclr FreeBSD_x64 Release succeeded
Details
runtime (Installer Build and Test coreclr Linux_arm Debug) Installer Build and Test coreclr Linux_arm Debug succeeded
Details
runtime (Installer Build and Test coreclr Linux_arm64 Release) Installer Build and Test coreclr Linux_arm64 Release succeeded
Details
runtime (Installer Build and Test coreclr Linux_musl_arm64 Debug) Installer Build and Test coreclr Linux_musl_arm64 Debug succeeded
Details
runtime (Installer Build and Test coreclr Linux_musl_x64 Release) Installer Build and Test coreclr Linux_musl_x64 Release succeeded
Details
runtime (Installer Build and Test coreclr Linux_x64 Release) Installer Build and Test coreclr Linux_x64 Release succeeded
Details
runtime (Installer Build and Test coreclr OSX_x64 Release) Installer Build and Test coreclr OSX_x64 Release succeeded
Details
runtime (Installer Build and Test coreclr Windows_NT_arm Debug) Installer Build and Test coreclr Windows_NT_arm Debug succeeded
Details
runtime (Installer Build and Test coreclr Windows_NT_arm64 Debug) Installer Build and Test coreclr Windows_NT_arm64 Debug succeeded
Details
runtime (Installer Build and Test coreclr Windows_NT_x64 Release) Installer Build and Test coreclr Windows_NT_x64 Release succeeded
Details
runtime (Installer Build and Test coreclr Windows_NT_x86 Debug) Installer Build and Test coreclr Windows_NT_x86 Debug succeeded
Details
runtime (Libraries Build FreeBSD x64 Debug) Libraries Build FreeBSD x64 Debug succeeded
Details
runtime (Libraries Build Linux arm Release) Libraries Build Linux arm Release succeeded
Details
runtime (Libraries Build Linux arm64 Debug) Libraries Build Linux arm64 Debug succeeded
Details
runtime (Libraries Build Linux x64 Debug) Libraries Build Linux x64 Debug succeeded
Details
runtime (Libraries Build Linux_musl arm64 Release) Libraries Build Linux_musl arm64 Release succeeded
Details
runtime (Libraries Build Linux_musl x64 Debug) Libraries Build Linux_musl x64 Debug succeeded
Details
runtime (Libraries Build OSX x64 Debug) Libraries Build OSX x64 Debug succeeded
Details
runtime (Libraries Build Windows_NT allConfigurations x64 Debug) Libraries Build Windows_NT allConfigurations x64 Debug succeeded
Details
runtime (Libraries Build Windows_NT arm Release) Libraries Build Windows_NT arm Release succeeded
Details
runtime (Libraries Build Windows_NT arm64 Release) Libraries Build Windows_NT arm64 Release succeeded
Details
runtime (Libraries Build Windows_NT net472 x86 Release) Libraries Build Windows_NT net472 x86 Release succeeded
Details
runtime (Libraries Build Windows_NT x64 Debug) Libraries Build Windows_NT x64 Debug succeeded
Details
runtime (Libraries Build Windows_NT x86 Debug) Libraries Build Windows_NT x86 Debug succeeded
Details
runtime (Libraries Build Windows_NT x86 Release) Libraries Build Windows_NT x86 Release succeeded
Details
runtime (Libraries Test Build Linux x64 Debug) Libraries Test Build Linux x64 Debug succeeded
Details
runtime (Libraries Test Build OSX x64 Debug) Libraries Test Build OSX x64 Debug succeeded
Details
runtime (Libraries Test Build Windows_NT x64 Debug) Libraries Test Build Windows_NT x64 Debug succeeded
Details
runtime (Libraries Test Run checked coreclr Linux arm Release) Libraries Test Run checked coreclr Linux arm Release succeeded
Details
runtime (Libraries Test Run checked coreclr Linux arm64 Debug) Libraries Test Run checked coreclr Linux arm64 Debug succeeded
Details
runtime (Libraries Test Run checked coreclr Linux x64 Debug) Libraries Test Run checked coreclr Linux x64 Debug succeeded
Details
runtime (Libraries Test Run checked coreclr Linux_musl arm64 Release) Libraries Test Run checked coreclr Linux_musl arm64 Release succeeded
Details
runtime (Libraries Test Run checked coreclr Linux_musl x64 Debug) Libraries Test Run checked coreclr Linux_musl x64 Debug succeeded
Details
runtime (Libraries Test Run checked coreclr OSX x64 Debug) Libraries Test Run checked coreclr OSX x64 Debug succeeded
Details
@RikkiGibson RikkiGibson deleted the RikkiGibson:IsExternalInit branch Jun 12, 2020
@msftbot msftbot bot locked as resolved and limited conversation to collaborators Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants