Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce allocation in NegotiateStream.Read/Write{Async} #37772

Merged
merged 3 commits into from Jun 12, 2020
Merged

Reduce allocation in NegotiateStream.Read/Write{Async} #37772

merged 3 commits into from Jun 12, 2020

Commits on Jun 11, 2020

  1. Avoid new byte[] per Write{Async} 

    Hold onto and reuse our write buffer.
    @stephentoub
    stephentoub committed Jun 11, 2020
    Configuration menu
    Copy the full SHA
    6b7a684 View commit details
    Browse the repository at this point in the history

  2. Avoid byte[][] allocation per Read/Write{Async}

    @stephentoub
    stephentoub committed Jun 11, 2020
    Configuration menu
    Copy the full SHA
    685a620 View commit details
    Browse the repository at this point in the history

  3. Avoid two boxing allocations per Read{Async} 

    The default interface method on the interface results in boxing a struct that implements that interface on each call to the method.
    @stephentoub
    stephentoub committed Jun 11, 2020
    Configuration menu
    Copy the full SHA
    0904519 View commit details
    Browse the repository at this point in the history