Narrow four utf16 chars to ascii and write to buffer #39508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgovind
force-pushed
the
NarrowFourUtf16CharsToAsciiAndWriteToBuffer
branch
from
16ce598
to
b22083f
Compare
|
Tagging subscribers to this area: @tannergooding |
pgovind
commented
Jul 18, 2020
| @@ -8,6 +8,8 @@ internal static class Vector64 | |||
| public static Vector64<ulong> Create(ulong value) => throw new PlatformNotSupportedException(); | |||
| public static Vector64<uint> CreateScalar(uint value) => throw new PlatformNotSupportedException(); | |||
| public static Vector64<byte> AsByte<T>(this Vector64<T> vector) where T : struct => throw new PlatformNotSupportedException(); | |||
| public static Vector64<T> GetLower<T>(this Vector128<T> vector) where T : struct => throw new PlatformNotSupportedException(); | |||
There was a problem hiding this comment.
These are not strictly needed for this PR, but all of these APIs will be needed in subsequent PRs. Let me know if you'd rather that I keep this clean.
echesakov
suggested changes
Jul 20, 2020
src/libraries/System.Private.CoreLib/src/System/Text/ASCIIUtility.cs
Outdated
Show resolved
Hide resolved
echesakov
approved these changes
Jul 20, 2020
src/libraries/System.Private.CoreLib/src/System/Text/ASCIIUtility.cs
Outdated
Show resolved
Hide resolved
pgovind
force-pushed
the
NarrowFourUtf16CharsToAsciiAndWriteToBuffer
branch
2 times, most recently
from
40c7685
to
c719dde
Compare
pgovind
force-pushed
the
NarrowFourUtf16CharsToAsciiAndWriteToBuffer
branch
from
c719dde
to
938efce
Compare
|
Rebasing on the latest master to see if CI passes |
|
CI failures are unrelated. Merging. |
Jacksondr5
pushed a commit
to Jacksondr5/runtime
that referenced
this pull request
Aug 10, 2020
* Shims * shim * Cherry-pick * NarrowFourUtf16CharsToAsciiAndWriteToBuffer * Address comments * Nit
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I decided to split up my single PR into multiple ones so I can isolate CI bugs better. I believe this change should be good to go in.
In the process of splitting, I eventually found that the ARM64 CI legs seem to be broken currently. I opened #39582 to test that claim.
Perf results:
Before and After Arm64 optimizations
calope@calopearm:~/performance/src/tools/ResultsComparer$ dotnet run --base ~/pgovind_before/ --diff ~/pgovind_after/ --threshold 0.01%
summary:
better: 1, geomean: 1.244
total diff: 1
No Slower results for the provided threshold = 0.01% and noise filter = 0.3ns.