Remove unused pinvokes for WinRT scenarios #39846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkoritzinsky
approved these changes
Jul 23, 2020
elinor-fung
approved these changes
Jul 23, 2020
src/libraries/Common/src/Interop/Windows/Mincore/Interop.GetRestrictedErrorInfo.cs
Show resolved
Hide resolved
|
@jkotas Am I missing anything with respect to some hidden usage or down level scenario? |
|
Hello @AaronRobinsonMSFT! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
|
The Linux musl x64 build isn't impacted for this and has been "running" for over 4 hrs. |
Jacksondr5
pushed a commit
to Jacksondr5/runtime
that referenced
this pull request
Aug 10, 2020
* Remove GetRestructedErrorInfo P/Invoke * Remove win32 core memory P/Invokes * Remove RoGetBufferMarshaler P/Invoke * Remove RoGetActivationFactory P/Invoke * Remove CoreComm P/Invokes * Remove IRestrictedErrorInfo definition.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since built-in support was for WinRT was removed (#37672), we can further remove these unused P/Invokes.
/cc @stephentoub @jkoritzinsky @elinor-fung