Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wasm] Mark DiagnosticSource.Switches.Tests with an active issue #39952

Merged

Conversation

MaximLipnin
Copy link
Contributor

System.Diagnostics.DiagnosticSource.Switches.Tests is mentioned in #38422 but actually this test suite depends on runtimeconfig.template.json file which is not supported on wasm at the moment (see #38433). So I just marked the test suite with the active issue.

@ghost
Copy link

ghost commented Jul 27, 2020

Tagging subscribers to this area: @safern, @ViktorHofer
See info in area-owners.md if you want to be subscribed.

@akoeplinger
Copy link
Member

Since this effectively disables the whole test suite we should instead add the ActiveIssue in an AssemblyInfo.cs and add <IgnoreForCI>true</IgnoreForCI> to the .csproj.

@akoeplinger akoeplinger merged commit 397bb22 into dotnet:master Jul 27, 2020
@MaximLipnin MaximLipnin deleted the wasm_DiagnosticSource.Switches.Tests branch July 28, 2020 07:39
Jacksondr5 pushed a commit to Jacksondr5/runtime that referenced this pull request Aug 10, 2020
@karelz karelz added this to the 5.0.0 milestone Aug 18, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants