Modified #41008 without GetOverlappedResultEx #41236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 23, 2020 10:35
|
Tagging subscribers to this area: @tommcdon |
jkotas
reviewed
Aug 23, 2020
jkotas
reviewed
Aug 23, 2020
|
coreclr pri0 Win-x64 failure is #40916 These failures don't look related to these changes; I'll rerun these two jobs. |
This was referenced Aug 25, 2020
noahfalk
approved these changes
Aug 25, 2020
src/libraries/System.Private.CoreLib/src/System/WeakReference.cs
Outdated
Show resolved
Hide resolved
josalem
force-pushed
the
dev/josalem/win7-friendly-41008
branch
from
032e692
to
691983d
Compare
|
Hello @josalem! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit
josalem
pushed a commit
to josalem/runtime
that referenced
this pull request
Aug 25, 2020
* Revert "Revert "Improve Windows error handling in Diagnostics IPC (dotnet#41008)" (dotnet#41220)" This reverts commit 15839c0. * don't use win8+ API
ghost
locked as resolved and limited conversation to collaborators
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #41217
Same changes as #41008 but without using
GetOverlappedResultExwhich is only available in Windows 8 forward. This modification does not change the behavior of the patch.Below is the PR description from #41008.
fixes #41007
These changes are intended to be backported to 5.0-rc1 once merged into master.
As described in #41007, the runtime was treating
ERROR_BROKEN_PIPEas a generic error rather than a hangup error. These changes correct that misbehavior and reset the connection on generic errors in case additional errors have been missed. Additionally, they simplify the logic ofIpcStream::{Read|Write}to useGetOverlappedResultExwhich directly takes a timeout rather thanGetOverlappedResultfollowed byWaitForSingleObject.CC @jander-msft @tommcdon
Customer Impact
This currently impacts
dotnet-monitoron Windows.If a Connect Diagnostic Port on Windows doesn't call
DisconnectNamedPipebefore closing it will cause runtimes to be unable to connect to another Connect Diagnostic Port at the same address. For example,dotnet-monitorcurrently does not callDisconnectNamedPipebefore closing, so if a user restartsdotnet-monitorthey won't see any apps show up if they connected before.Testing
I have tested these changes locally with
dotnet-monitorboth under a debugger and without the debugger. These fix the observed issue. I did not add an individual test for this scenario, but one could be created.Risk
This is a low risk patch. It simply improves the error handling and corrects a misbehavior.