-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add HTTP Request/Response Headers/Content Start/Stop events #41590
Conversation
Tagging subscribers to this area: @dotnet/ncl |
/azp run runtime-libraries outerloop |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In Request(Start/Stop)
we are guarding against dangling Stop
events with telemetryStarted
booleans. Also Stop
s are called in finally
blocks so the events are paired properly in all cases.
Any reason we forgo this with these events?
RequestStart/Stop are also updating the internal request started/aborted/finished numbers used by Counters. The extra logic around them is to ensure counters are reporting correct values. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
* System.Net Telemetry style changes (#41527) * Change HandshakeStop SslProtocols parameter to enum * Parameterize Http11/Http20 events * Add dummy request to ensure Http2 settings are received * Moved HTTP request telemetry to HttpClient.SendAsync (#41022) * Moved HTTP request telemetry to HttpClient.SendAsync * Added ResponseContent and helper methods events. * Rework helper method activity nesting * Expand Telemetry tests * Also log RequestStart/Stop in HttpMessageInvoker * Update RequestStart signature * RequestAborted => RequestFailed rename * ResponseContent Begin => Start/Stop * Fix HttpMessageInvoker implementation * Add Synchronous request Telemetry tests * Check telemetryStarted before ResponseContentStart Co-authored-by: MihaZupan <mihazupan.zupan1@gmail.com> * Add Request/Response Headers/Content Start/Stop events (#41590) Co-authored-by: Marie Píchová <11718369+ManickaP@users.noreply.github.com>
ResponseHeadersBegin
RequestHeadersStart
,RequestHeadersStop
RequestContentStart
,RequestContentStop(long contentLength)
ResponseHeadersStart
,ResponseHeadersStop