Suppress C5105 warning on build #41900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @ViktorHofer |
|
Turns out I didn't need to update CMakeLists.txt on my box. Updating only configurecompiler.cmake was sufficient. |
hoyosjs
approved these changes
Sep 4, 2020
josalem
approved these changes
Sep 5, 2020
ghost
locked as resolved and limited conversation to collaborators
|
/backport to release/5.0 |
|
Started backporting to release/5.0: https://github.com/dotnet/runtime/actions/runs/519188441 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #41886.
MSVC included with latest VS nightly performs stricter preprocessor conformance checks. These checks currently produce warnings on the Windows SDK header file winbase.h, which is failing our build. This PR suppresses this warning code so that we can continue to import this header file successfully.
This is only intended to be a temporary workaround to unblock development. We'll make a more permanent fix when we receive guidance from the MSVC or the Windows SDK team.