Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete unused multibyte methods from PAL #42157

Merged
merged 1 commit into from
Sep 13, 2020
Merged

Delete unused multibyte methods from PAL #42157

merged 1 commit into from
Sep 13, 2020

Conversation

am11
Copy link
Member

@am11 am11 commented Sep 12, 2020

CreateProcessA had an occurrence in ToolBox, where LPSTR was converted to LPWSTR.

@am11
Copy link
Member Author

am11 commented Sep 12, 2020

cc @jkotas, this PR has not removed the A methods which are used by their W counterparts (e.g. SetEnvironmentVariableA, CopyFileA, MoveFileA etc.).

@jkotas jkotas merged commit c867337 into dotnet:master Sep 13, 2020
@am11 am11 deleted the feature/cleanup/pal/multibyte branch September 13, 2020 02:34
@davidwrighton
Copy link
Member

@am11 Could you hold off on checking in any more changes that reformat code in the PAL tests for a week or so? My larger work item to return these tests to running in CI is running into repeated merge conflicts.

Thank you.

@am11
Copy link
Member Author

am11 commented Sep 14, 2020

Sure, sorry about the conflicts. I just realize it (few hours ago, #42049 (comment)). :(
I have a unix script which I run before checkin that removes trailing whitespaces from the code files, which are included in the commits from tip of my local branch to upstream's master:

#!/usr/bin/env sh

# assuming remote name 'dotnet' is present (after user/org GH naming)
# git remote dotnet https://github.com/dotnet/runtime

# if file exists in (combined) delta, clear the trailing white-spaces:
$ git show --name-only --pretty="" HEAD...dotnet/master |\
    xargs -I{} sh -c "test -f {} && sed -i '' 's/[[:space:]]*$//' {}"

@ghost ghost locked as resolved and limited conversation to collaborators Dec 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants