Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V3 publishing for Runtime #42262

Merged
merged 3 commits into from
Sep 17, 2020
Merged

V3 publishing for Runtime #42262

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6da8d68
V3 publishing (#41899)
epananth Sep 9, 2020
1a076ba
Update arcade sdk (#42044)
epananth Sep 10, 2020
c2b36d0
Merge branch 'master' of https://github.com/dotnet/runtime into test
epananth Sep 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion eng/pipelines/official/stages/publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
parameters:
PublishRidAgnosticPackagesFromPlatform: Windows_NT_x64
publishingInfraVersion: 3

stages:

Expand All @@ -23,6 +24,7 @@ stages:
# Stages-based publishing entry point
- template: /eng/common/templates/post-build/post-build.yml
parameters:
publishingInfraVersion: ${{ parameters.publishingInfraVersion }}
validateDependsOn:
- PrepareForPublish
# The following checks are run after the build in the validation and release pipelines
Expand All @@ -47,6 +49,6 @@ stages:
-TsaRepositoryName "$(TsaRepositoryName)"
-TsaCodebaseName "$(TsaCodebaseName)"
-TsaPublish $True

# Publish to blob storage.
publishInstallersAndChecksums: true
10 changes: 6 additions & 4 deletions src/installer/publish/prepare-artifacts.proj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,13 +88,14 @@
<PushToAzureDevOpsArtifacts
ItemsToPush="@(ItemsToPush)"
ManifestBuildData="@(ManifestBuildData)"
ManifestRepoUri="$(BUILD_REPOSITORY_URI)"
ManifestRepoUri="$(BUILD_REPOSITORY_NAME)"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this repo have a new enough arcade to use ManifestRepoName instead of ManifestRepoUri?

Copy link
Member Author

@epananth epananth Sep 15, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Master got a arcade update 2 days ago -> #41796

Also repo name is reflected in the manifests

image

image

image

ManifestBranch="$(BUILD_SOURCEBRANCH)"
ManifestBuildId="$(BUILD_BUILDNUMBER)"
ManifestCommit="$(BUILD_SOURCEVERSION)"
IsStableBuild="$(IsStableBuild)"
AssetManifestPath="$(AssetManifestFile)"
AssetsTemporaryDirectory="$(TempWorkingDir)" />
AssetsTemporaryDirectory="$(TempWorkingDir)"
PublishingVersion="3" />

<!-- Copy the generated manifest to the build's artifacts -->
<Copy SourceFiles="$(AssetManifestFile)" DestinationFolder="$(TempWorkingDir)" />
Expand Down Expand Up @@ -153,14 +154,15 @@
<PushToAzureDevOpsArtifacts
ItemsToPush="@(ItemsToPush)"
ManifestBuildData="@(ManifestBuildData)"
ManifestRepoUri="$(BUILD_REPOSITORY_URI)"
ManifestRepoUri="$(BUILD_REPOSITORY_NAME)"
ManifestBranch="$(BUILD_SOURCEBRANCH)"
ManifestBuildId="$(BUILD_BUILDNUMBER)"
ManifestCommit="$(BUILD_SOURCEVERSION)"
IsStableBuild="$(IsStableBuild)"
PublishFlatContainer="true"
AssetManifestPath="$(AssetManifestFile)"
AssetsTemporaryDirectory="$(TempWorkingDir)" />
AssetsTemporaryDirectory="$(TempWorkingDir)"
PublishingVersion ="3" />

<!-- Copy the generated manifest to the build's artifacts -->
<Copy SourceFiles="$(AssetManifestFile)" DestinationFolder="$(TempWorkingDir)" />
Expand Down