[release/5.0-rc2] Backport Additional Browser Unsupported Attribute Changes #42267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
Co-authored-by: Mitchell Hwang <mitchell.hwang@microsoft.com>
…net#42063) * Mark some System.Net.HttpListener APIs as unsupported on browser * FIx windows builds * Fix windows builds * Remove browser annotations from the properties with windows-specific setters. * Mark only setter of ExtendedProtectionPolicy * Remove another redundant annotation
…r WASM (dotnet#42010) * Mark System.Security.Cryptography.Algorithms as unsupported on Browser WASM * Address the comment regarding IncrementalHash.CreateHMAC * Group System.* usings * Restore the blank lines between the meta-comment and the code for all the HMAC classes * Fix style issues * Mark MD5 class as unsupported on Browser; clean up the api exclusion list and proj file. * Using * Style fix
mdh1418
force-pushed
the
mdhwang/backport_unsupported_browser_attributes_second_round
branch
from
059e6ea
to
ea8ab67
Compare
mdh1418
changed the title
mdh1418
requested review from
lewing,
vargaz,
marek-safar,
steveisok,
EgorBo and
akoeplinger
mdh1418
added
arch-wasm
71 tasks
|
@lewing please send it for approval ASAP |
pranavkm
approved these changes
Sep 16, 2020
lewing
added
Servicing-approved
mdh1418
deleted the
mdhwang/backport_unsupported_browser_attributes_second_round
branch
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue
Ongoing analyzer work.
Master PR
#41976 #42074 #42063 #42010
Description
The Platform Compatibility Analyzer can be used to identify APIs that are problematic on other specific platforms or deprecated. With the attribute
UnsupportedOSPlatformAttribute("browser"), numerous APIs that are not supported on Browser WASM are marked for the platform compatibility analyzer to pick up.Customer Impact
Without this fix, customers will not be warned against using certain unsupported APIs on Browser WASM. Importantly some Http request settings and the cryptography APIs that are not supported.
Risk
Low. These attributes only impact the compatibility analyzer for browser-wasm.