Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address JSON test failures #42960

Merged
merged 1 commit into from
Oct 2, 2020
Merged

Address JSON test failures #42960

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/libraries/System.Text.Json/tests/Serialization/ContinuationTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ private static IEnumerable<bool> IgnoreNullValues

[Theory]
[MemberData(nameof(TestData))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/42677", platforms: TestPlatforms.Windows, runtimes: TestRuntimes.Mono)]
public static async Task ContinuationShouldWorkAtAnyPosition_Class_Class(int paddingLength, bool ignoreNullValues)
{
var stream = new MemoryStream();
Expand Down Expand Up @@ -86,6 +87,7 @@ public static async Task ContinuationShouldWorkAtAnyPosition_Class_Class(int pad

[Theory]
[MemberData(nameof(TestData))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/42677", platforms: TestPlatforms.Windows, runtimes: TestRuntimes.Mono)]
public static async Task ContinuationShouldWorkAtAnyPosition_Class_ValueType(int paddingLength, bool ignoreNullValues)
{
var stream = new MemoryStream();
Expand Down Expand Up @@ -141,6 +143,7 @@ public static async Task ContinuationShouldWorkAtAnyPosition_Class_ValueType(int

[Theory]
[MemberData(nameof(TestData))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/42677", platforms: TestPlatforms.Windows, runtimes: TestRuntimes.Mono)]
public static async Task ContinuationShouldWorkAtAnyPosition_ValueType_Class(int paddingLength, bool ignoreNullValues)
{
var stream = new MemoryStream();
Expand Down Expand Up @@ -197,6 +200,7 @@ public static async Task ContinuationShouldWorkAtAnyPosition_ValueType_Class(int

[Theory]
[MemberData(nameof(TestData))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/42677", platforms: TestPlatforms.Windows, runtimes: TestRuntimes.Mono)]
public static async Task ContinuationShouldWorkAtAnyPosition_ValueType_ValueType(int paddingLength, bool ignoreNullValues)
{
var stream = new MemoryStream();
Expand Down Expand Up @@ -252,6 +256,7 @@ public static async Task ContinuationShouldWorkAtAnyPosition_ValueType_ValueType

[Theory]
[MemberData(nameof(TestData))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/42677", platforms: TestPlatforms.Windows, runtimes: TestRuntimes.Mono)]
public static async Task ContinuationShouldWorkAtAnyPosition_ClassWithParamCtor_Class(int paddingLength, bool ignoreNullValues)
{
var stream = new MemoryStream();
Expand Down Expand Up @@ -385,6 +390,7 @@ public override void Write(Utf8JsonWriter writer, Outer<T> value, JsonSerializer
[Theory]
[InlineData("CustomerSearchApi108KB")]
[InlineData("CustomerSearchApi107KB")]
[ActiveIssue("https://github.com/dotnet/runtime/issues/42677", platforms: TestPlatforms.Windows, runtimes: TestRuntimes.Mono)]
public static async Task ContinuationAtNullToken(string resourceName)
{
using (Stream stream = new MemoryStream(Encoding.UTF8.GetBytes(SR.GetResourceString(resourceName))))
Expand Down
1 change: 1 addition & 0 deletions src/libraries/System.Text.Json/tests/Serialization/EnumConverterTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,6 +314,7 @@ public enum MyEnum
}

[Fact, OuterLoop]
[ActiveIssue("https://github.com/dotnet/runtime/issues/42677", platforms: TestPlatforms.Windows, runtimes: TestRuntimes.Mono)]
public static void VeryLargeAmountOfEnumDictionaryKeysToSerialize()
{
// Ensure we don't throw OutOfMemoryException.
Expand Down
3 changes: 2 additions & 1 deletion src/libraries/System.Text.Json/tests/Serialization/InvalidJsonTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -315,7 +315,8 @@ public static IEnumerable<object[]> DataForInvalidJsonForTypeTests()
yield return new object[] { typeof(Dictionary<string, Dictionary<string, Poco>>), @"{""key"":1}" };
}

[Fact]
[Fact, OuterLoop]
[ActiveIssue("https://github.com/dotnet/runtime/issues/42677", platforms: TestPlatforms.Windows, runtimes: TestRuntimes.Mono)]
public static void InvalidJsonForTypeShouldFail()
{
foreach (object[] args in DataForInvalidJsonForTypeTests()) // ~140K tests, too many for theory to handle well with our infrastructure
Expand Down