Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove IsRuntimeRepository checks #43

Merged
merged 4 commits into from
Nov 15, 2019
Merged

Remove IsRuntimeRepository checks #43

merged 4 commits into from
Nov 15, 2019

Conversation

ViktorHofer
Copy link
Member

No description provided.

@ViktorHofer ViktorHofer self-assigned this Nov 14, 2019
@ViktorHofer ViktorHofer added area-Infrastructure NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) labels Nov 14, 2019
@ViktorHofer
Copy link
Member Author

We should wait with merging this until we have better CI coverage.

@ViktorHofer ViktorHofer mentioned this pull request Nov 14, 2019
Closed
trylek
trylek approved these changes Nov 14, 2019
View reviewed changes
Copy link
Member

@trylek trylek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love so much red. FWIW there's one more bit like this in

runtime/eng/pipelines/coreclr/templates/xplat-pipeline-job.yml

Line 87 in 125444d

- ${{ if not(startsWith(variables['Build.DefinitionName'], 'runtime')) }}:

I don't insist on removing it in this particular change though.

Thanks

Tomas

@ViktorHofer
Copy link
Member Author

Thanks, I updated the PR.

@ViktorHofer ViktorHofer removed the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Nov 14, 2019
@ViktorHofer
Copy link
Member Author

Somebody please merge this PR later if you think that CI results are expressive enough.

@trylek
Copy link
Member

trylek commented Nov 14, 2019

The one libraries bug looks like something Viktor fixed independently (@wfurt's incomplete checkin of the serial port freebsd changes into the coreclr repo right before the migration) so hopefully this is just a job ordering issue and should end up green once merged.

@safern
Copy link
Member

safern commented Nov 15, 2019

The installer failure is the regression caused in arcade for windows pdbs.

The coreclr failures are similar to:

System.IO.FileLoadException: Could not load file or assembly 'Interop.StructPacking.XUnitWrapper, Version=0.0.0.0, Culture=neutral, PublicKeyToken=null'. An operation is not legal in the current state. (0x80131509 (COR_E_INVALIDOPERATION))

System.IO.FileLoadException: Could not load file or assembly 'JIT.SIMD.XUnitWrapper, Version=0.0.0.0, Culture=neutral, PublicKeyToken=null'. An operation is not legal in the current state. (0x80131509 (COR_E_INVALIDOPERATION))

The libraries failure should be fixed by: #53

@trylek do the coreclr failures look familiar? I guess we can merge this.

@ViktorHofer
Copy link
Member Author

Yes that failure is undeterministic failure that we are currently trying to diagnose.

@ViktorHofer ViktorHofer merged commit d8f6d63 into dotnet:master Nov 15, 2019
@ViktorHofer ViktorHofer deleted the RemoveRuntimeChecks branch November 15, 2019 00:50
MichalStrehovsky added a commit to MichalStrehovsky/runtime that referenced this pull request Aug 11, 2020
@MichalStrehovsky @dotnet-bot
Copy build task over from CoreRT repo (dotnet#43)
0a59f67 
* Copy build task over from CoreRT repo

At CoreRT commit b48a58e6facdda7f50f9256e0d9d6a209473132f.

* Hook up ILCompiler.Build.Tasks to build

Co-authored-by: dotnet-bot <dotnet-bot@microsoft.com>
@karelz karelz added this to the 5.0.0 milestone Aug 18, 2020
@lauxjpn lauxjpn mentioned this pull request Oct 20, 2020
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Dec 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@trylek trylek trylek approved these changes

@safern safern safern approved these changes

Assignees

@ViktorHofer ViktorHofer

Labels
area-Infrastructure
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ViktorHofer @trylek @safern @karelz @jkoritzinsky