Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IL Offset and Method Token to stacktrace #44013

Merged
merged 14 commits into from
Apr 12, 2021

Commits on Mar 31, 2021

  1. Add IL Offset and Method Token to stacktrace

    For easier debugging, if the PDB is not deployed, add the Method Token and IL Offset to the stacktrace.
    This functionality can be turned on and off by environment setting "COMPlus_ILOffsetToStackTrace"
    wscho77 committed Mar 31, 2021
    Configuration menu
    Copy the full SHA
    c77d3be View commit details
    Browse the repository at this point in the history
  2. Use LocalAppContextSwitch and HexConverter

    Use LocalAppContextSwitch to get environment variable without using static constructor in StackTrace.
    Also, use HexConverter to get metadata token and il offset without unnecessary complex.
    wscho77 committed Mar 31, 2021
    Configuration menu
    Copy the full SHA
    a7f6060 View commit details
    Browse the repository at this point in the history
  3. Use AppendFormat instead of HexConverter

    Use AppendFormat() for formatting of the hex number.
    wscho77 committed Mar 31, 2021
    Configuration menu
    Copy the full SHA
    99f96fa View commit details
    Browse the repository at this point in the history
  4. Use switch to activate ILOffset in stacktrace

    - Change switch name from ILOffsetsToStackTrace to ShowILOffset
    - Use "Switch.System.Diagnostics.StackTrace.ShowILOffsets" to activate ILOffset in stacktrace
    - Use "DOTNET_" prefix for environment variable name (DOTNET_ILOffsetToStackTrace)
    wscho77 committed Mar 31, 2021
    Configuration menu
    Copy the full SHA
    90479a1 View commit details
    Browse the repository at this point in the history

Commits on Apr 1, 2021

  1. Configuration menu
    Copy the full SHA
    7b3f838 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    af7c84b View commit details
    Browse the repository at this point in the history
  3. Remove unused variable

    wscho77 committed Apr 1, 2021
    Configuration menu
    Copy the full SHA
    62350d8 View commit details
    Browse the repository at this point in the history

Commits on Apr 2, 2021

  1. Configuration menu
    Copy the full SHA
    c54d679 View commit details
    Browse the repository at this point in the history

Commits on Apr 7, 2021

  1. Update src/libraries/System.Private.CoreLib/src/System/LocalAppContex…

    …tSwitches.cs
    
    Co-authored-by: Noah Falk <noahfalk@users.noreply.github.com>
    wscho77 and noahfalk committed Apr 7, 2021
    Configuration menu
    Copy the full SHA
    870543a View commit details
    Browse the repository at this point in the history

Commits on Apr 8, 2021

  1. TC contents are added

    wscho77 committed Apr 8, 2021
    Configuration menu
    Copy the full SHA
    8ee5242 View commit details
    Browse the repository at this point in the history
  2. Remove setting code using enviornment variable

    remove setting code using environment variable and change switch default value to true.
    wscho77 committed Apr 8, 2021
    Configuration menu
    Copy the full SHA
    a3e2476 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    a10ebfc View commit details
    Browse the repository at this point in the history
  4. Sort using statements

    wscho77 committed Apr 8, 2021
    Configuration menu
    Copy the full SHA
    c63a0c8 View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2021

  1. Skipt test in mono interpreter mode.

    Related issue : dotnet#51096
    wscho77 committed Apr 12, 2021
    Configuration menu
    Copy the full SHA
    8c85326 View commit details
    Browse the repository at this point in the history