Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the minimum and target version of the SDK to 5.0.100 #44523

Closed
wants to merge 1 commit into from

Conversation

ViktorHofer
Copy link
Member

@ViktorHofer ViktorHofer commented Nov 11, 2020

Part of December's batched rollout: #44524

The release/5.0 branch will automatically be updated via Arcade to 5.0.100. Updating master as well to be on the same sdk and use the latest released bits instead of a preview version. This also bumps the minimum required version as illink needs a >= 5.0 RC2 SDK anyway.

The release/5.0 branch will automatically be updated via Arcade to 5.0.100. Updating master as well to be on the same sdk and use the latest released bits instead of a preview version. This also bumps the minimum required version as illink needs a >= 5.0 RC2 SDK anyway.
@ViktorHofer ViktorHofer added the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Nov 11, 2020
@ViktorHofer ViktorHofer self-assigned this Nov 11, 2020
@ghost
Copy link

ghost commented Nov 11, 2020

Tagging subscribers to this area: @ViktorHofer
See info in area-owners.md if you want to be subscribed.


Issue meta data

Issue content: **Part of December's batched rollout: https://github.com//issues/44524**

The release/5.0 branch will automatically be updated via Arcade to 5.0.100. Updating master as well to be on the same sdk and use the latest released bits instead of a preview version. This also bumps the minimum required version as illink needs a >= 5.0 RC2 SDK anyway.

Issue author: ViktorHofer
Assignees: ViktorHofer
Milestone: -

Copy link
Member

@safern safern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@huoyaoyuan
Copy link
Member

Please consider to align the required SDK in global.json with the version shipped with VS whenever possible.

It's interesting that not updating global.json will break contribution experience. When VS updates to stable 5.0.100, the build script will start downloading RC2.

The source used in dotnet-install script is much slower than VS installer or official downloads. I have to manually install RC2 sdk back to get better building experience.

@safern
Copy link
Member

safern commented Nov 25, 2020

@huoyaoyuan we have a strict policy of only updating the SDK once a month during our infrastructure rollout as it is a breaking change. We're going to be merging this on the first day of December, so next week.

@ViktorHofer
Copy link
Member Author

Small correction, first Monday of the month

@safern
Copy link
Member

safern commented Nov 25, 2020

Small correction, first Monday of the month

Thanks, @ViktorHofer. So then it will not be next week, but the week after, since next Monday is the 30th 😄

@ViktorHofer
Copy link
Member Author

Closing as this has been done already via a darc auto update.

@ViktorHofer ViktorHofer closed this Dec 7, 2020
@jkotas jkotas deleted the ViktorHofer-sdk5.0.100 branch December 8, 2020 16:38
@ghost ghost locked as resolved and limited conversation to collaborators Jan 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Infrastructure NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants