Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RyuJIT] static readonly fields can be Invariant #44562

Merged
merged 9 commits into from
Mar 2, 2021
Merged

[RyuJIT] static readonly fields can be Invariant #44562

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
b56e447
Address feedback
EgorBo Feb 18, 2021
5990de8
Merge branch 'master' of github.com:dotnet/runtime into jit-static-re…
EgorBo Feb 19, 2021
c9abebc
Merge branch 'master' of github.com:dotnet/runtime into jit-static-re…
EgorBo Feb 25, 2021
a89448e
Merge branch 'master' of github.com:dotnet/runtime into jit-static-re…
EgorBo Feb 25, 2021
61f7ea3
Apply suggestions from code review
EgorBo Feb 25, 2021
43360d3
Merge branch 'jit-static-readonly-field-invariant' of github.com:Egor…
EgorBo Feb 25, 2021
c4d4878
Merge branch 'main' of github.com:dotnet/runtime into jit-static-read…
EgorBo Mar 1, 2021
aa9f1a4
ignore RelocTypeHint for statically inited readonly fields
EgorBo Mar 1, 2021
12c0aea
Update morph.cpp
EgorBo Mar 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/coreclr/jit/morph.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6490,6 +6490,15 @@ GenTree* Compiler::fgMorphField(GenTree* tree, MorphAddrContext* mac)
tree->SetOper(GT_IND);
tree->AsOp()->gtOp1 = addr;

bool plsSpeculative = true;
if ((info.compCompHnd->getStaticFieldCurrentClass(symHnd, &plsSpeculative) != NO_CLASS_HANDLE) &&
!plsSpeculative)
{
EgorBo marked this conversation as resolved.
Show resolved Hide resolved
JITDUMP("Marking static read-only field '%s' as invariant.\n", eeGetFieldName(symHnd));
EgorBo marked this conversation as resolved.
Show resolved Hide resolved
tree->gtFlags |= GTF_IND_INVARIANT;
EgorBo marked this conversation as resolved.
Show resolved Hide resolved
addr->gtFlags = GTF_ICON_CONST_PTR;
}

return fgMorphSmpOp(tree);
}
else
Expand Down