Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark R2RDumpTests as incompatible with GC stress #44586

Merged
merged 2 commits into from
Nov 12, 2020

Conversation

trylek
Copy link
Member

@trylek trylek commented Nov 12, 2020

The purpose of this test is not to stress the runtime, it's relatively
lengthy as it processes the entire System.Private.CoreLib framework
assembly and so it's timing out in GC stress runs.

Thanks

Tomas

The purpose of this test is not to stress the runtime, it's relatively
lengthy as it processes the entire System.Private.CoreLib framework
assembly and so it's timing in GC stress runs.

Thanks

Tomas
@trylek trylek added this to the 6.0.0 milestone Nov 12, 2020
@trylek
Copy link
Member Author

trylek commented Nov 12, 2020

FYI @BruceForstall who typically triages GC stress test failures ;-)

@trylek trylek added this to In progress + Investigations in Core-Runtime .net 9 Nov 12, 2020
Copy link
Member

@janvorli janvorli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

Copy link
Member

@cshung cshung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A single line comment on why that is so would be nice.

@trylek trylek merged commit dcd63bb into dotnet:master Nov 12, 2020
@trylek trylek deleted the R2RDumpTestsNoGCStress branch November 12, 2020 23:05
@ghost ghost locked as resolved and limited conversation to collaborators Dec 13, 2020
@trylek trylek moved this from In progress + Investigations to Complete in Core-Runtime .net 9 Feb 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants