Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating darc dependencies and enabling closure #45386

Closed
wants to merge 0 commits into from
Closed

Updating darc dependencies and enabling closure #45386

wants to merge 0 commits into from

Conversation

Anipik
Copy link
Contributor

@Anipik Anipik commented Nov 30, 2020

Fixes #44078

@ghost
Copy link

ghost commented Nov 30, 2020

Tagging subscribers to this area: @safern, @ViktorHofer
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #44078

Author: Anipik
Assignees: -
Labels:

area-Infrastructure-libraries

Milestone: -

@ericstj
Copy link
Member

ericstj commented Dec 4, 2020

Looks like libraries build is failing with

C:\Program Files\dotnet\sdk\5.0.100\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Sdk.FrameworkReferenceResolution.targets(324,5): error NETSDK1127: (NETCORE_ENGINEERING_TELEMETRY=Build) The targeting pack Microsoft.NETCore.App is not installed. Please restore and try again.

I think this has to do with

<KnownFrameworkReference Include="Microsoft.NETCore.App"

However I wouldn't expect us to be using the built-in ref pack for net6.0. We should hook that and use the one that was just built.

@ViktorHofer
Copy link
Member

// Auto-generated message

69e114c which was merged 12/7 removed the intermediate src/coreclr/src/ folder. This PR needs to be updated as it touches files in that directory which causes conflicts.

To update your commits you can use this bash script: https://gist.github.com/ViktorHofer/6d24f62abdcddb518b4966ead5ef3783. Feel free to use the comment section of the gist to improve the script for others.

@safern
Copy link
Member

safern commented Dec 8, 2020

I think this has to do with

People are hitting this error whenever they don't have the rc1 targeting pack installed.
#45755

@ghost ghost locked as resolved and limited conversation to collaborators Feb 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Assembly Versions to 6.0.0.0
5 participants