Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Start thread pool worker threads in the default execution context #46181

Merged
merged 10 commits into from
Dec 19, 2020
Merged

Start thread pool worker threads in the default execution context #46181

merged 10 commits into from
Dec 19, 2020

Commits on Dec 17, 2020

  1. Start thread pool worker threads in the default execution context 

    The execution context transfers to new threads, and this creates an extra stack frame on the thread and may cause AsyncLocal value change notifications to be sent unnecessarily. Switched to the default context before creating a worker thread.
    @kouvel
    kouvel committed Dec 17, 2020
    Configuration menu
    Copy the full SHA
    b53cc03 View commit details
    Browse the repository at this point in the history

  2. Simplify EC changes as suggested 

    Co-authored-by: Jan Kotas <jkotas@microsoft.com>
    @kouvel @jkotas
    kouvel and jkotas committed Dec 17, 2020
    Configuration menu
    Copy the full SHA
    b9684d4 View commit details
    Browse the repository at this point in the history

  3. Revert to using Capture to prevent flow-suppressed ECs from flowing

    @kouvel
    kouvel committed Dec 17, 2020
    Configuration menu
    Copy the full SHA
    1059217 View commit details
    Browse the repository at this point in the history

  4. Add test, similarly fix gate thread and wait thread creations, minor … 

    …changes
    @kouvel
    kouvel committed Dec 17, 2020
    Configuration menu
    Copy the full SHA
    15415e3 View commit details
    Browse the repository at this point in the history

  5. Minor undo of minor changes before

    @kouvel
    kouvel committed Dec 17, 2020
    Configuration menu
    Copy the full SHA
    5b29acc View commit details
    Browse the repository at this point in the history

  6. Add test to verify EC flow to new threads

    @kouvel
    kouvel committed Dec 17, 2020
    Configuration menu
    Copy the full SHA
    d3e9029 View commit details
    Browse the repository at this point in the history

Commits on Dec 18, 2020

  1. Update thread creation in Mono to flow EC

    @kouvel
    kouvel committed Dec 18, 2020
    Configuration menu
    Copy the full SHA
    f58e178 View commit details
    Browse the repository at this point in the history

  2. Add internal Thread.UnsafeStart that does not propagate the EC and … 

    …use that instead
    @kouvel
    kouvel committed Dec 18, 2020
    Configuration menu
    Copy the full SHA
    65222e2 View commit details
    Browse the repository at this point in the history

  3. Clear saved EC before calling start callback

    @kouvel
    kouvel committed Dec 18, 2020
    Configuration menu
    Copy the full SHA
    b97b0fe View commit details
    Browse the repository at this point in the history

  4. Similarly update portable implementation of timer

    @kouvel
    kouvel committed Dec 18, 2020
    Configuration menu
    Copy the full SHA
    caf5e21 View commit details
    Browse the repository at this point in the history