Remove most unnecessary resources from PNSE assemblies and partial facade assemblies

[danmoseley]

Fix #28888

1. Disable resources from partial facades by default
2. Reenable in a few projects where the PF's have some code that needs resources.
3. Change PNSE assemblies to use a separate NotSupported.resx by default, and move their single resources there
4. Except for a few projects where the PNSE assemblies have some code that needs resources
5. Incidentally remove some strings named PlatformNotSupported_XX that appeared to be dead.

Other than the PNSE resources, I didn't split any Strings.resx's -- in a few cases I looked at, there were only a few strings different between different configurations, but there may be cases where there are larger differences (eg., many Windows specific strings)

Not sure how to best measure, but artifacts\packages\Debug\Shipping is about 300KB smaller

[ghost]

Tagging subscribers to this area: @safern, @ViktorHofer
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Fix #46181

1. Disable resources from partial facades by default
2. Reenable in a few projects where the PF's have some code that needs resources.
3. Change PNSE assemblies to use a separate NotSupported.resx by default, and move their single resources there
4. Except for a few projects where the PNSE assemblies have some code that needs resources
5. Incidentally remove some strings named PlatformNotSupported_XX that appeared to be dead.

Other than the PNSE resources, I didn't split any Strings.resx's -- in a few cases I looked at, there were only a few strings different between different configurations, but there may be cases where there are larger differences (eg., many Windows specific strings)

Not sure how to best measure, but artifacts\packages\Debug\Shipping is about 300KB smaller

Author:	danmosemsft
Assignees:	-
Labels:	area-Infrastructure-libraries
Milestone:	-

[kouvel]

Think the issue link above is incorrect, it points to my PR :)

[danmoseley]

Fixed, copy paste error - gosh I didn't create this very cleanly.

[danmoseley]

Failing test fixed by #46564

[danmoseley]

@stephentoub do you have any other feedback?

[stephentoub]

Nope

[danmoseley]

@safern @ViktorHofer perhaps one of you could review?

[safern]

Looks reasonable. @ericstj might be interested on this change as well.

[ericstj]

Rather than checking all this in, can we just generate it to obj? It seems these all match the same template.

[danmoseley]

Hmm, good idea. I don't know why that didn't occur to me.

[ericstj]

I suggested the resx in the issue, so it was my fault 😆

[ericstj]

Not sure how to best measure, but artifacts\packages\Debug\Shipping is about 300KB smaller

That'll be compressed and won't show you the improvements you made to shared framework size. You could enumerate all dlls under artifacts\bin that are PNSE's and measure before and after when doing allconfigs build. I believe you can observe a PNSE by reading this attribute:

[assembly: AssemblyMetadata("NotSupported", "True")]

[danmoseley]

Draftifying until I have time to do that. It will be a few days.

[ghost]

Draft Pull Request was automatically closed for inactivity. It can be manually reopened in the next 30 days if the work resumes.

[danmoseley]

There are some PNSE messages that are not formulaic. If we generate them centrally, they would become System.XXX is not supported on this platform.. I guess that is OK

eg

Access Control List (ACL) APIs are specific to the way in which Windows manages access to resources, and are not supported on this platform.
Customized reflection contexts are only supported on .NET Framework.
System.IO.Ports is currently only supported on Windows.
System.Management currently is only supported for Windows desktop applications.
System.Net.WebClient is not supported on this platform. Use System.Net.Http.HttpClient instead.
WinHttpHandler is only supported on .NET Framework and .NET runtimes on Windows. It is not supported for Windows Store Applications (UWP) or Unix platforms.

[ericstj]

A property value could specify that if you want (there may already be one), or you could say that folks which want to customize the message can use the checked in resx model.