Refactor more of thread creation into shared CoreLib partition #46244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkotas
requested review from
akoeplinger,
EgorBo,
marek-safar,
steveisok and
vargaz
as code owners
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
|
Follow up on #46181 (comment) |
|
The mono changes look ok to me. |
jkotas
force-pushed
the
thread-refactor
branch
from
ecec27b
to
876b663
Compare
jkotas
force-pushed
the
thread-refactor
branch
from
401ff9a
to
d854652
Compare
jkotas
added a commit
to jkotas/runtime
that referenced
this pull request
Dec 24, 2020
jkotas
added a commit
that referenced
this pull request
Dec 25, 2020
lambdageek
added a commit
to lambdageek/runtime
that referenced
this pull request
Jan 13, 2021
…otnet#46390)" This reverts commit 43d0780.
monojenkins
pushed a commit
to monojenkins/mono
that referenced
this pull request
Jan 13, 2021
Revert dotnet/runtime#46390 which reverted the Mono parts of dotnet/runtime#46244. Fixes dotnet/runtime#46389 The issue was that the code in dotnet/runtime#46244 throws in `Thread` constructors before calling `Initialize`. Which will then cause a finalizer to run on a partially-initialized thread object, which means that `ves_icall_System_Threading_InternalThread_Thread_free_internal` will be called with a null `MonoInternalThread:longlived` field.
jkotas
pushed a commit
that referenced
this pull request
Jan 13, 2021
* Revert "Partial rollback of #46244 to workaround #46389 (#46390)" This reverts commit 43d0780. * [threads] Check for null longlived thread data This might happen on netcore if the managed Thread constructor throws an exception before calling InitInternal. In that case the finalizer may see a partially initialized object.
akoeplinger
pushed a commit
to mono/mono
that referenced
this pull request
Jan 13, 2021
Revert dotnet/runtime#46390 which reverted the Mono parts of dotnet/runtime#46244. Fixes dotnet/runtime#46389 The issue was that the code in dotnet/runtime#46244 throws in `Thread` constructors before calling `Initialize`. Which will then cause a finalizer to run on a partially-initialized thread object, which means that `ves_icall_System_Threading_InternalThread_Thread_free_internal` will be called with a null `MonoInternalThread:longlived` field. Co-authored-by: lambdageek <lambdageek@users.noreply.github.com>
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.