Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Unix FileStatus flag retrieval without perf regression #47348

Closed
wants to merge 31 commits into from
Closed

Fix Unix FileStatus flag retrieval without perf regression #47348

wants to merge 31 commits into from

Commits on Jan 21, 2021

  1. New hidden and readonly tests

    @carlossanlop
    carlossanlop committed Jan 21, 2021
    Configuration menu
    Copy the full SHA
    a50c0fc View commit details
    Browse the repository at this point in the history

  2. FileStatus.Unix.cs public->internal

    @carlossanlop
    carlossanlop committed Jan 21, 2021
    Configuration menu
    Copy the full SHA
    b8f69b7 View commit details
    Browse the repository at this point in the history

  3. FileStatus.Unix.cs sort members

    @carlossanlop
    carlossanlop committed Jan 21, 2021
    Configuration menu
    Copy the full SHA
    84433dd View commit details
    Browse the repository at this point in the history

  4. FileStatus.Unix.cs brackets

    @carlossanlop
    carlossanlop committed Jan 21, 2021
    Configuration menu
    Copy the full SHA
    5070cde View commit details
    Browse the repository at this point in the history

  5. Add VerifyStatCall method

    @carlossanlop
    carlossanlop committed Jan 21, 2021
    Configuration menu
    Copy the full SHA
    0686368 View commit details
    Browse the repository at this point in the history

  6. Use VerifyStatCall with existing FileStatus Lstat call

    @carlossanlop
    carlossanlop committed Jan 21, 2021
    Configuration menu
    Copy the full SHA
    5e5932b View commit details
    Browse the repository at this point in the history

  7. FileStatus.Unix.cs sort Initialize method

    @carlossanlop
    carlossanlop committed Jan 21, 2021
    Configuration menu
    Copy the full SHA
    a866e73 View commit details
    Browse the repository at this point in the history

  8. Rename _fileStatus => _mainCache, _fileStatusInitialized => _initiali… 

    …zedMainCache
    @carlossanlop
    carlossanlop committed Jan 21, 2021
    Configuration menu
    Copy the full SHA
    48d0d5a View commit details
    Browse the repository at this point in the history

  9. Add _secondaryCache and _initializedSecondaryCache

    @carlossanlop
    carlossanlop committed Jan 21, 2021
    Configuration menu
    Copy the full SHA
    96dd50c View commit details
    Browse the repository at this point in the history

  10. Add IsValid. Use it where value of _initializedMainCache is checked.

    @carlossanlop
    carlossanlop committed Jan 21, 2021
    Configuration menu
    Copy the full SHA
    f6b35c3 View commit details
    Browse the repository at this point in the history

  11. Update EnsureStatInitialized to check both _initialized* values

    @carlossanlop
    carlossanlop committed Jan 21, 2021
    Configuration menu
    Copy the full SHA
    f865030 View commit details
    Browse the repository at this point in the history

  12. Adjust VerifyStatCall to consider ENOENT, ENOTDIR as 'path not exists… 

    …' cases, but not failure. Use _secondaryCache and _initializedSecondaryCache.
    @carlossanlop
    carlossanlop committed Jan 21, 2021
    Configuration menu
    Copy the full SHA
    334b561 View commit details
    Browse the repository at this point in the history

  13. Add and consume IsSymbolicLink and HasSymbolicLinkFlag.

    @carlossanlop
    carlossanlop committed Jan 21, 2021
    Configuration menu
    Copy the full SHA
    e8e5d9b View commit details
    Browse the repository at this point in the history

  14. Fix Refresh stat call error verification to prevent bug in SymLinksMa… 

    …yExistIndependentlyOfTarget unit test (link should exist after main file deleted).
    @carlossanlop
    carlossanlop committed Jan 21, 2021
    Configuration menu
    Copy the full SHA
    82c382f View commit details
    Browse the repository at this point in the history

  15. Use Invalidate to reset _initialized* values

    @carlossanlop
    carlossanlop committed Jan 21, 2021
    Configuration menu
    Copy the full SHA
    4dbb740 View commit details
    Browse the repository at this point in the history

  16. Add HasReadOnlyFlag and consume in GetAttributes and IsReadOnly

    @carlossanlop
    carlossanlop committed Jan 21, 2021
    Configuration menu
    Copy the full SHA
    b3cb947 View commit details
    Browse the repository at this point in the history

  17. Add HasHiddenFlag and IsHidden and consume in SetAttributes

    @carlossanlop
    carlossanlop committed Jan 21, 2021
    Configuration menu
    Copy the full SHA
    a69901b View commit details
    Browse the repository at this point in the history

Commits on Jan 22, 2021

  1. Add IsDirectory and HasDirectoryFlag 

        Need to preserve the _isDirectory field. The order and the place in which it acquires a value matter. It should also be set to false when EnsureStatInitialized is called. The unit test that verifies this is System.IO.Tests.DirectoryInfo_Exists.SymLinksMayExistIndependentlyOfTarget.
    @carlossanlop
    carlossanlop committed Jan 22, 2021
    Configuration menu
    Copy the full SHA
    9dc2681 View commit details
    Browse the repository at this point in the history

  2. Remove Initialize. Call Invalidate and InitiallyDirectory directly on… 

    … both usage cases.
    @carlossanlop
    carlossanlop committed Jan 22, 2021
    Configuration menu
    Copy the full SHA
    6ba7c79 View commit details
    Browse the repository at this point in the history

  3. FileSystemEntry.Initialize should get stat info via its FileStatus in… 

    …stance.
    @carlossanlop
    carlossanlop committed Jan 22, 2021
    Configuration menu
    Copy the full SHA
    4b3aec0 View commit details
    Browse the repository at this point in the history

  4. FileSystemEntry.Initialize should get lstat info via its FileStatus i… 

    …nstance.
    @carlossanlop
    carlossanlop committed Jan 22, 2021
    Configuration menu
    Copy the full SHA
    75552fe View commit details
    Browse the repository at this point in the history

  5. Combine FileSystemEntry.IsHidden dot check with flag check.

    @carlossanlop
    carlossanlop committed Jan 22, 2021
    Configuration menu
    Copy the full SHA
    62b77b8 View commit details
    Browse the repository at this point in the history

  6. Move internal static FileSystemInfo.Create logic into FileSystemEntry… 

    ….ToFileSystemInfo, since it's the only place where it is used. Move the Debug.Assert to the top with the ROS<char> instead of the string.
    @carlossanlop
    carlossanlop committed Jan 22, 2021
    Configuration menu
    Copy the full SHA
    ac7062b View commit details
    Browse the repository at this point in the history

  7. In FileSystemEntry, only refresh each cache when needed.

    @carlossanlop
    carlossanlop committed Jan 22, 2021
    Configuration menu
    Copy the full SHA
    c4aa27f View commit details
    Browse the repository at this point in the history

  8. Rename EnsureStatInitialized to EnsureCachesInitialized

    @carlossanlop
    carlossanlop committed Jan 22, 2021
    Configuration menu
    Copy the full SHA
    371d1a4 View commit details
    Browse the repository at this point in the history

  9. Rename Refresh to RefreshCaches

    @carlossanlop
    carlossanlop committed Jan 22, 2021
    Configuration menu
    Copy the full SHA
    f9e1619 View commit details
    Browse the repository at this point in the history

  10. Add ThrowOnCacheInitializationError

    @carlossanlop
    carlossanlop committed Jan 22, 2021
    Configuration menu
    Copy the full SHA
    6c489ad View commit details
    Browse the repository at this point in the history

  11. Only refresh relevant cache for IsHidden, IsReadOnly and IsSymbolicLink

    @carlossanlop
    carlossanlop committed Jan 22, 2021
    Configuration menu
    Copy the full SHA
    136e2c3 View commit details
    Browse the repository at this point in the history

  12. Ensure FileSystemEntry.IsHidden refreshes cache if needed. Invert Fil… 

    …eSystemEntry.Initialize calls to refresh individual caches.
    @carlossanlop
    carlossanlop committed Jan 22, 2021
    Configuration menu
    Copy the full SHA
    43476e7 View commit details
    Browse the repository at this point in the history

  13. Add FileSystemEntry.HasHiddenPrefix to check for dot in name. Do soft… 

    … hidden check in Initialize to prevent perf regression.
    @carlossanlop
    carlossanlop committed Jan 22, 2021
    Configuration menu
    Copy the full SHA
    a869d2c View commit details
    Browse the repository at this point in the history

  14. Fix test comments

    @carlossanlop
    carlossanlop committed Jan 22, 2021
    Configuration menu
    Copy the full SHA
    76dd793 View commit details
    Browse the repository at this point in the history