Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Interlocked.CompareExchange/Exchange to shared #47368

Merged
merged 3 commits into from Jan 23, 2021
Merged

Move Interlocked.CompareExchange/Exchange to shared #47368

merged 3 commits into from Jan 23, 2021

Conversation

EgorBo
Copy link
Member

@EgorBo EgorBo commented Jan 23, 2021

Fixes #47266

@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@monojenkins monojenkins mentioned this pull request Jan 23, 2021
Merged
CoffeeFlux
CoffeeFlux reviewed Jan 23, 2021
View reviewed changes
Copy link
Contributor

@CoffeeFlux CoffeeFlux left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One note for Mono, looks good to me otherwise. Thanks!

src/mono/mono/metadata/icall-def-netcore.h Show resolved Hide resolved
jkotas
jkotas approved these changes Jan 23, 2021
View reviewed changes
Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jkotas
Copy link
Member

jkotas commented Jan 23, 2021

Failures are #47374

@jkotas jkotas merged commit 01116d4 into dotnet:master Jan 23, 2021
@dotnet dotnet locked as resolved and limited conversation to collaborators Feb 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@CoffeeFlux CoffeeFlux CoffeeFlux left review comments

@vargaz vargaz vargaz approved these changes

@jkotas jkotas jkotas approved these changes

@akoeplinger akoeplinger Awaiting requested review from akoeplinger

@lambdageek lambdageek Awaiting requested review from lambdageek

@lateralusX lateralusX Awaiting requested review from lateralusX

@marek-safar marek-safar Awaiting requested review from marek-safar

@steveisok steveisok Awaiting requested review from steveisok

@thaystg thaystg Awaiting requested review from thaystg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Poor code quality for Interlocked.{Compare}Exchange(nint)
5 participants
@EgorBo @jkotas @vargaz @stephentoub @CoffeeFlux