Revert "Use socketpair to implement Process.Start redirection" #47461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @eiriktsarpalis Issue DetailsReverts #34861 to address the regression reported in #46469. The goal is to backport the revert to cc @jeffhandley.
|
stephentoub
reviewed
Jan 26, 2021
src/libraries/System.Diagnostics.Process/tests/ProcessStreamReadTests.cs
Show resolved
Hide resolved
eiriktsarpalis
force-pushed
the
revert-processsocketpair
branch
from
2858601
to
e43ad7b
Compare
stephentoub
reviewed
Jan 29, 2021
src/libraries/System.Diagnostics.Process/tests/ProcessStreamReadTests.cs
Outdated
Show resolved
Hide resolved
…adTests.cs Co-authored-by: Stephen Toub <stoub@microsoft.com>
|
/backport to release/5.0 |
|
Started backporting to release/5.0: https://github.com/dotnet/runtime/actions/runs/521211331 |
|
@eiriktsarpalis backporting to release/5.0 failed, the patch most likely resulted in conflicts: $ git am --3way --ignore-whitespace --keep-non-patch changes.patch
Applying: Revert #34861
error: sha1 information is lacking or useless (src/libraries/Native/Unix/System.Native/pal_process.c).
error: could not build fake ancestor
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Revert #34861
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Error: The process '/usr/bin/git' failed with exit code 128Please backport manually! |
|
😢 |
eiriktsarpalis
added a commit
to eiriktsarpalis/runtime
that referenced
this pull request
Jan 29, 2021
…t#47461) * Revert dotnet#34861 * reinstate removed test * Update src/libraries/System.Diagnostics.Process/tests/ProcessStreamReadTests.cs Co-authored-by: Stephen Toub <stoub@microsoft.com> Co-authored-by: Stephen Toub <stoub@microsoft.com>
Anipik
pushed a commit
that referenced
this pull request
Feb 10, 2021
… (#47644) * Revert "Use socketpair to implement Process.Start redirection" (#47461) * Revert #34861 * reinstate removed test * Update src/libraries/System.Diagnostics.Process/tests/ProcessStreamReadTests.cs Co-authored-by: Stephen Toub <stoub@microsoft.com> Co-authored-by: Stephen Toub <stoub@microsoft.com> * Add test validating against regression in #46469 (#47643) * Add test validating against regression in #46469 * fix test bug Co-authored-by: Stephen Toub <stoub@microsoft.com>
|
Is it included in 5.0.3? |
|
If all goes to schedule, 5.0.4 would be March patch Tuesday. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #34861 to address the regression reported in #46469. The goal is to backport the revert to
release-5.0and consider a different approach for 6 (e.g. the changes in #44647).cc @jeffhandley.