-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Mono][LLVM][ARM] Implemented Arm64 Abs intrinsic #47482
Conversation
break; | ||
case INTRINS_ADV_SIMD_ABS_INT64: | ||
intrins = add_intrins1 (module, id, sse_i8_t); | ||
break; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The whole function looks like the work to define signatures for intrinsics could be done via macros in llvm-intrinsics.h
instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have macros to do this type of thing, or were you suggesting I create some? I would have think think a little about how to do it; this function predates my changes and would need some reworking.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I mean in general, if you want to eventually implement the full set of intrinsics it makes sense to minimize verbosity of the changes.
07c77da
to
cd96ca9
Compare
23828a7
to
5c4dd0d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. So this is the first AdvSimd.Arm64
API that is being supported in mono?
Yes. I am working on implement more; the issue listing them all is here: #42266 |
Got it. I have added a reference to the documentation that I worked few months back to explain what every AdvSimd.Arm64 intrinsic API does. In case it is helpful to you or anyone working on this feature. |
Implements AdvSimd.Abs intrinsic on arm64 with LLVM.