Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable EHWrite thru #47702

Closed
wants to merge 4 commits into from
Closed

Enable EHWrite thru #47702

wants to merge 4 commits into from

Conversation

kunalspathak
Copy link
Member

DO NOT MERGE : This is an experimental PR to see if jitstressregs and jitstressregs - libraries work with EH write thru on.

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Feb 1, 2021
@kunalspathak kunalspathak added NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) NO-REVIEW Experimental/testing PR, do NOT review it and removed area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI labels Feb 1, 2021
@naricc
Copy link
Member

naricc commented Feb 1, 2021

What is EHWrite thru? Some kind of cache write thru?

@kunalspathak
Copy link
Member Author

What is EHWrite thru? Some kind of cache write thru?

It is write thru the values to stack as well as register if the method has exception handling (EH) code. See #35923 for more context.

@AndyAyersMS
Copy link
Member

What is EHWrite thru?

There's a good writeup here: Exception Handling Write Through Optimization.

@kunalspathak
Copy link
Member Author

Another experiment to see if "Combine free and busy alloc" work in #45135 broke EhWriteThru scenarios.

@kunalspathak
Copy link
Member Author

Failures after reverting "Combine busy and free alloc" work is minimal in "runtime-coreclr jitstressregs". So probably, that work introduced issues in EHWriteThru scenarios.

@kunalspathak
Copy link
Member Author

Failures after reverting "Combine busy and free alloc" work is minimal in "runtime-coreclr jitstressregs". So probably, that work introduced issues in EHWriteThru scenarios.

Not sure which results I was checking out, but seems there are failures even before "Combine busy and free alloc", so possibly EHWriteThru default was never verified still jitstressregs?

@ghost ghost locked as resolved and limited conversation to collaborators Mar 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) NO-REVIEW Experimental/testing PR, do NOT review it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kunalspathak @naricc @AndyAyersMS