enable SslStream_ClientCertificate_SendsChain test on macOS #48209
Conversation
wfurt
added
os-mac-os-x
|
Tagging subscribers to this area: @dotnet/ncl, @vcsjones Issue DetailsThe reason why this was failing is different from #46837.
|
| public async Task SslStream_ClientCertificate_SendsChain() | ||
| { | ||
| List<SslStream> streams = new List<SslStream>(); | ||
| TestHelper.CleanupCertificates("SslStream_ClinetCertificate_SendsChain"); | ||
| (X509Certificate2 clientCertificate, X509Certificate2Collection clientChain) = TestHelper.GenerateCertificates("SslStream_ClinetCertificate_SendsChain", serverCertificate: false); | ||
| using (X509Store store = new X509Store(StoreName.CertificateAuthority, StoreLocation.CurrentUser)) | ||
| using (X509Store store = new X509Store(PlatformDetection.IsOSXLike ? StoreName.My : StoreName.CertificateAuthority, StoreLocation.CurrentUser)) |
There was a problem hiding this comment.
Can we add a comment explaining why OSX is different?
There was a problem hiding this comment.
ok. I will. It is primarily #48207 but there still seems to be another trickery in CI. I'm looking into it and I'll hold this back until clean CI pass.
|
Draft Pull Request was automatically closed for inactivity. It can be manually reopened in the next 30 days if the work resumes. |
ghost
locked as resolved and limited conversation to collaborators
The reason why this was failing is different from #46837.
I changed where we store intermediate certificates and did little bit more refactoring on CleanupCertificates as I did not want to add third identical block. #46837 will need additional work.