Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix isByteReg() assert for x86 #48830

Merged
merged 3 commits into from
Mar 3, 2021
Merged

Fix isByteReg() assert for x86 #48830

merged 3 commits into from
Mar 3, 2021

Commits on Feb 26, 2021

  1. [Windows x86] Fix isByteReg() assert 

    The change is similar to the one done in dotnet#46567. If the type if `BYTE`, the use byte regs.

Fixes the following failures:

https://helixre8s23ayyeko0k025g8.blob.core.windows.net/dotnet-runtime-refs-pull-47307-head-c9ab37658a344842be/System.Linq.Queryable.Tests/console.2ce37104.log?sv=2019-07-07&se=2021-03-10T08%3A39%3A45Z&sr=c&sp=rl&sig=GdS1KlEkJHVcKz7lwpZeszudWYokZpr%2Bt7IGv4c61co%3D

https://helixre8s23ayyeko0k025g8.blob.core.windows.net/dotnet-runtime-refs-pull-47307-head-c9ab37658a344842be/System.Linq.Tests/console.4bc4fd10.log?sv=2019-07-07&se=2021-03-10T08%3A39%3A45Z&sr=c&sp=rl&sig=GdS1KlEkJHVcKz7lwpZeszudWYokZpr%2Bt7IGv4c61co%3D
    @kunalspathak
    kunalspathak committed Feb 26, 2021
    Configuration menu
    Copy the full SHA
    98baa88 View commit details
    Browse the repository at this point in the history

Commits on Mar 3, 2021

  1. add an assert in allRegs()

    @kunalspathak
    kunalspathak committed Mar 3, 2021
    Configuration menu
    Copy the full SHA
    91d9602 View commit details
    Browse the repository at this point in the history

  2. Revert "add an assert in allRegs()" 

    This reverts commit 91d9602.
    @kunalspathak
    kunalspathak committed Mar 3, 2021
    Configuration menu
    Copy the full SHA
    956e756 View commit details
    Browse the repository at this point in the history